Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previewing email templates in admin loads admin area CSS #27543

Closed
erfanimani opened this issue Apr 2, 2020 · 3 comments · Fixed by #27828
Closed

Previewing email templates in admin loads admin area CSS #27543

erfanimani opened this issue Apr 2, 2020 · 3 comments · Fixed by #27828
Assignees
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.4 Indicates original Magento version for the Issue report. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@erfanimani
Copy link
Contributor

erfanimani commented Apr 2, 2020

Preconditions (*)

  1. Magento 2.3.4, but this happens to other versions too

Steps to reproduce (*)

  1. In the admin, navigate to Marketing -> Email Templates
  2. Load a template and hit Preview Template

Expected result (*)

  1. Email looks as "true" as possible, without any interference of CSS unrelated to the actual email

Actual result (*)

  1. Admin CSS interferes with how the email looks

The issue is simply that admin CSS is loaded when previewing email templates, which could interfere with how the emails show up as. With the Luma emails this difference is not much, some minor typography changes. However, when designing email templates from scratch, this could have a big effect — making the Preview Template functionality useless.

See screenshot below. Essentially there are two pages, one is the outer page (preview), and one is the inner page/iframe (popup). The iframe exists supposedly to isolate CSS changes. However, that's rendered moot as admin CSS is also loaded inside the iframe.

image

@m2-assistant
Copy link

m2-assistant bot commented Apr 2, 2020

Hi @erfanimani. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@erfanimani do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ghost ghost added this to Ready for QA in Community Backlog Apr 2, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 2, 2020
@ghost ghost assigned mrtuvn Apr 12, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Apr 12, 2020
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Apr 24, 2020
@slavvka slavvka linked a pull request Apr 24, 2020 that will close this issue
4 tasks
@sdzhepa sdzhepa added the Triage: Done Has been reviewed and prioritized during Triage with Product Managers label Apr 30, 2020
@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label May 21, 2020
@slavvka
Copy link
Member

slavvka commented May 21, 2020

@slavvka slavvka closed this as completed May 21, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog May 21, 2020
@magento-engcom-team magento-engcom-team removed this from Done (last 30 days) in Community Backlog May 21, 2020
@magento-engcom-team
Copy link
Contributor

Based on the provided information internal tickets MC-34531 were created.

@magento-engcom-team magento-engcom-team added the Reported on 2.3.4 Indicates original Magento version for the Issue report. label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.4 Indicates original Magento version for the Issue report. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Development

Successfully merging a pull request may close this issue.

5 participants