Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwanted styles for email preview #27828

Merged
merged 10 commits into from
May 21, 2020
Merged

Remove unwanted styles for email preview #27828

merged 10 commits into from
May 21, 2020

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Apr 12, 2020

Description (*)

Remove unrelated css from layout when preview email template

Related Pull Requests

Fixed Issues (if relevant)

  1. Previewing email templates in admin loads admin area CSS #27543: Previewing email templates in admin loads admin area CSS

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 12, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Apr 12, 2020
lbajsarowicz
lbajsarowicz previously approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve that change - verified on mailhog and e-mails seem to be fine
This needs advanced QA tests.

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 13, 2020
@ghost ghost assigned lbajsarowicz Apr 13, 2020
@ghost ghost moved this from Ready for Testing to Pending Review in Pull Requests Dashboard Apr 13, 2020
@ghost ghost dismissed lbajsarowicz’s stale review April 13, 2020 11:47

Pull Request state was updated. Re-review required.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7350 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 15, 2020
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 20, 2020

@lbajsarowicz can u update label tests for QA tests

@engcom-Delta engcom-Delta self-assigned this Apr 23, 2020
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 23, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Before:
#27828Main

After:
Preview Luma theme
#27828PR
Email Luma Theme
#27828PREmailLuma
Preview Blank theme
#27828PRBlank
Email Blank Theme
#27828PREmailBlank

@engcom-Delta engcom-Delta moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 23, 2020
@engcom-Echo engcom-Echo self-assigned this Apr 24, 2020
@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Apr 24, 2020
@slavvka slavvka added Award: bug fix Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Apr 24, 2020
@slavvka slavvka added this to the 2.4.1 milestone Apr 24, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Apr 24, 2020
@slavvka slavvka linked an issue Apr 24, 2020 that may be closed by this pull request
Previewing email templates in admin loads admin area CSS #27543
Closed
@slavvka slavvka mentioned this pull request May 21, 2020
Closed
slavvka added a commit that referenced this pull request May 21, 2020
@slavvka
ENGCOM-7350: Remove unwanted styles for email preview #27828
5f33e66
@slavvka slavvka merged commit 9359acc into magento:2.4-develop May 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 21, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard May 21, 2020
@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard May 21, 2020
@sdzhepa sdzhepa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label May 22, 2020
@mrtuvn mrtuvn deleted the fix-27543-remove-unwanted-styles-for-email-preview branch June 7, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Email Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

Previewing email templates in admin loads admin area CSS
7 participants
@mrtuvn @magento-engcom-team @engcom-Delta @engcom-Echo @lbajsarowicz @sdzhepa @slavvka