Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology installation fails silently #27904

Closed
bartoszkubicki opened this issue Apr 20, 2020 · 10 comments
Closed

Topology installation fails silently #27904

bartoszkubicki opened this issue Apr 20, 2020 · 10 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.3.3 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@bartoszkubicki
Copy link

bartoszkubicki commented Apr 20, 2020

Preconditions (*)

  1. Magento 2.3.3, PHP 7.3, Rabbit 3.7.8

Steps to reproduce (*)

  1. Create topology having, for example queue, which causes exceptions from php-ampqlib, for example redeclare queue with different arguments values. (Possible if these PR are processed: Passing arguments for queues as expected #26966, Fix for queue numeric argument conversion #26967)
  2. Magento topology installer catches exception, but only logs it, so we have a failure of installation, but in bin/magento setup:upgrade there is no info about that.
  3. Caused here - vendor/magento/framework-amqp/TopologyInstaller.php:96

Expected result (*)

  1. If whole setup:upgrade isn't stop, at least we have some message in the end, what went wrong

Actual result (*)

  1. No info, so we pretend that setup went well.
@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2020

Hi @bartoszkubicki. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@bartoszkubicki do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ghost ghost added this to Ready for QA in Community Backlog Apr 20, 2020
@bartoszkubicki bartoszkubicki changed the title Topology installation failures are handled silently Topology installation failurs silently Apr 20, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 20, 2020
@bartoszkubicki bartoszkubicki changed the title Topology installation failurs silently Topology installation fails silently Apr 20, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@sidolov sidolov added this to Ready for Confirmation in Issue Confirmation and Triage Board Oct 21, 2020
@ghost ghost removed this from Ready for QA in Community Backlog Oct 21, 2020
@ghost ghost removed this from Ready for Grooming in Low Priority Backlog Oct 21, 2020
@ghost ghost added Issue: ready for confirmation and removed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Oct 21, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.3 Indicates original Magento version for the Issue report. label Nov 13, 2020
@stale
Copy link

stale bot commented Jan 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Jan 29, 2021
@bartoszkubicki
Copy link
Author

It should not be stale. It's need reviewing from @magento-engcom-team and decision if and how it can be fixed. My proposal is not catching an exception, so user is informed in console that something went wrong, not only in logs.

@stale stale bot removed the stale issue label Jan 29, 2021
@engcom-Delta engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Feb 3, 2021
@stale
Copy link

stale bot commented Apr 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Apr 20, 2021
@bartoszkubicki
Copy link
Author

Of course it is not resolved yet.

@m2-assistant
Copy link

m2-assistant bot commented Jun 8, 2021

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel engcom-Hotel self-assigned this Jun 14, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jun 14, 2021

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel engcom-Hotel added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: needs update Additional information is require, waiting for response labels Jun 14, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Jun 14, 2021
@m2-community-project m2-community-project bot removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: ready for confirmation labels Jun 14, 2021
@engcom-Hotel
Copy link
Contributor

Hi @bartoszkubicki ,

We have checked this issue on Magento version 2.4-develop but this is not reproducible. The issues mentioned in the ticket has been already merged with 2.4-develop.

Please check the issue with the version 2.4-develop and let us know if you found any issue.

@engcom-Hotel
Copy link
Contributor

Hi @bartoszkubicki ,

I hope that your issue is resolved because we did not get any update on this since 14 days. Hence closing the ticket.

Please feel free to raise the new ticket if you have any other issue. We will be happy to work for you.

@bartoszkubicki
Copy link
Author

@engcom-Hotel I didn't have time recently to check it again. I was waiting for your response for over one year, so I don't think this should be closed just like this. I am going to examine that in two next week, so you can reopen this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.3.3 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

No branches or pull requests

5 participants