Fix for queue numeric argument conversion #26967

bartoszkubicki · 2020-02-21T16:20:07Z

Description (*)

If we want to declare queue (I bet this also occurs the same way for exchanges) with arguments and we use numeric type argument in queue_topology.xml it is casted to string and in corrected file it gets wrapped in incorrect type for rabbit. Example of configuration:

 <exchange name="test.dead_letter" type="topic" connection="amqp">
        <binding id="test" topic="#" destinationType="queue"
                 destination="test_dead_letter">
            <arguments>
                <argument name="x-dead-letter-exchange" xsi:type="string">test.retry</argument>
                <argument name="x-message-ttl" xsi:type="number">36000</argument>
            </arguments>
        </binding>
    </exchange>

Of course using string type doesn't help as we get also string. While creating such a queue we get error similar to:
PRECONDITION_FAILED - inequivalent arg 'x-message-ttl'for queue 'test_dead_letter' in vhost '\': received the value '36000' of type 'longstr' but current is none.

If PR will be accepted, please port to 2.3 as well.

Related Pull Requests

This one has to be fixed first, as for now we are not able to declare queue with ANY parameters
#26966

Manual testing scenarios (*)

Declare queue with numeric argument, for example x-message-ttl
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Fix for queue numeric argument conversion #29615: Fix for queue numeric argument conversion

m2-assistant · 2020-02-21T16:20:10Z

Hi @bartoszkubicki. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

naydav · 2020-02-21T22:52:25Z

lib/internal/Magento/Framework/Amqp/Topology/ArgumentProcessor.php

@@ -17,22 +22,25 @@ trait ArgumentProcessor
     * @param array $arguments
     * @return array
     */
-    public function processArguments($arguments)
+    public function processArguments($arguments): array
    {
        $output = [];
        foreach ($arguments as $key => $value) {
            if (is_array($value)) {
                $output[$key] = ['A', $value];
            } elseif (is_int($value)) {


In this case, using only is_numeric will be enough.
Thanks

you mean in scope of this PR is_int check should be removed, while keeping is_numeric check?

@bartoszkubicki Yes, you are right, is_int check can be removed.

sidolov · 2020-08-17T18:42:58Z

@magento create issue

sidolov · 2020-08-27T20:32:01Z

lib/internal/Magento/Framework/Amqp/Topology/ArgumentProcessor.php

@@ -17,22 +22,25 @@ trait ArgumentProcessor
     * @param array $arguments
     * @return array
     */
-    public function processArguments($arguments)
+    public function processArguments($arguments): array
    {
        $output = [];
        foreach ($arguments as $key => $value) {
            if (is_array($value)) {
                $output[$key] = ['A', $value];
            } elseif (is_int($value)) {


@bartoszkubicki Yes, you are right, is_int check can be removed.

bartoszkubicki · 2020-08-27T21:14:25Z

@naydav @sidolov corrected

sidolov · 2020-08-27T21:18:01Z

@magento run all tests

sidolov · 2020-09-01T14:59:40Z

@bartoszkubicki could you please cover changes with automated tests?

engcom-Foxtrot · 2020-10-12T15:13:36Z

dev/tests/integration/testsuite/Magento/Framework/MessageQueue/TopologyTest.php

@@ -121,7 +132,7 @@ public function exchangeDataProvider()
                        'arguments' => [
                            'argument1' => 'value',
                            'argument2' => true,
-                            'argument3' => 150,
+                            'argument3' => '150',


The idea is to assert argument3 is a number.

bartoszkubicki · 2020-10-12T19:15:25Z

@magento run all tests

engcom-Foxtrot · 2020-10-15T13:12:54Z

@magento run all tests

engcom-Foxtrot · 2020-10-16T13:18:25Z

QA passed.

m2-assistant · 2020-10-24T10:38:22Z

Hi @bartoszkubicki, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

bartoszkubicki · 2020-10-25T19:29:36Z

Please port it to Magento 2.3

ghost added the Progress: pending review label Feb 21, 2020

magento-engcom-team added Component: Amqp Release Line: 2.4 labels Feb 21, 2020

bartoszkubicki force-pushed the queue-exchange-argument-processor-fix branch 2 times, most recently from 5951404 to cc49897 Compare February 21, 2020 16:23

bartoszkubicki changed the title ~~Fix for numeric argument conversion~~ Fix for queue numeric argument conversion Feb 21, 2020

This was referenced Feb 21, 2020

Making message lock release possible #26968

Open

Queue_topology.xml queue declaration #26969

Closed

naydav reviewed Feb 21, 2020

View reviewed changes

ghost assigned naydav Feb 21, 2020

magento-engcom-team added this to Pending Review in Pull Requests Dashboard Mar 24, 2020

bartoszkubicki mentioned this pull request Apr 20, 2020

Topology installation fails silently #27904

Closed

sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020

This was referenced Aug 17, 2020

[Issue] Fix for queue numeric argument conversion #29615

Closed

[Issue] Making message lock release possible #29616

Open

sidolov requested changes Aug 27, 2020

View reviewed changes

ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Aug 27, 2020

ghost assigned sidolov Aug 27, 2020

ghost added Progress: needs update and removed Progress: pending review labels Aug 27, 2020

Fix for numeric argument conversion

d60cbb9

bartoszkubicki force-pushed the queue-exchange-argument-processor-fix branch from cc49897 to d60cbb9 Compare August 27, 2020 21:13

Merge branch '2.4-develop' into queue-exchange-argument-processor-fix

5e7d9f6

Adding unit test

314ec92

engcom-Foxtrot requested changes Oct 12, 2020

View reviewed changes

ghost moved this from Extended Testing (optional) to Changes Requested in Pull Requests Dashboard Oct 12, 2020

ghost added Progress: needs update and removed Progress: extended testing labels Oct 12, 2020

Possible fix for integration test

8c8b9cf

bartoszkubicki force-pushed the queue-exchange-argument-processor-fix branch from c0fd215 to 8c8b9cf Compare October 12, 2020 18:35

engcom-Foxtrot added a commit to andrewbess/magento2ce that referenced this pull request Oct 13, 2020

magento#26967: Fix for queue numeric argument conversion - tests fix.

950d8a0

Merge branch '2.4-develop' into queue-exchange-argument-processor-fix

0c6d204

engcom-Foxtrot approved these changes Oct 16, 2020

View reviewed changes

ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Oct 16, 2020

ghost added Progress: ready for testing and removed Progress: needs update labels Oct 16, 2020

engcom-Foxtrot moved this from Ready for Testing to Extended Testing (optional) in Pull Requests Dashboard Oct 16, 2020

ghost added Progress: extended testing and removed Progress: ready for testing labels Oct 16, 2020

engcom-Foxtrot added QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) and removed Progress: extended testing labels Oct 16, 2020

engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Oct 16, 2020

engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Oct 16, 2020

ghost added the Progress: accept label Oct 16, 2020

magento-engcom-team pushed a commit that referenced this pull request Oct 24, 2020

ENGCOM-8155: Fix for queue numeric argument conversion #26967

996177c

magento-engcom-team merged commit fad43a1 into magento:2.4-develop Oct 24, 2020

ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Oct 24, 2020

magento-engcom-team added the Event: MageCONF CD 2020 label Oct 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for queue numeric argument conversion #26967

Fix for queue numeric argument conversion #26967

bartoszkubicki commented Feb 21, 2020 •

edited by m2-assistant bot

m2-assistant bot commented Feb 21, 2020

naydav Feb 21, 2020

bartoszkubicki Feb 21, 2020 •

edited

bartoszkubicki Apr 20, 2020

sidolov Aug 27, 2020

sidolov commented Aug 17, 2020

sidolov Aug 27, 2020

bartoszkubicki commented Aug 27, 2020

sidolov commented Aug 27, 2020

sidolov commented Sep 1, 2020

engcom-Foxtrot Oct 12, 2020 •

edited

bartoszkubicki commented Oct 12, 2020

engcom-Foxtrot commented Oct 15, 2020

engcom-Foxtrot commented Oct 16, 2020

m2-assistant bot commented Oct 24, 2020

bartoszkubicki commented Oct 25, 2020

Fix for queue numeric argument conversion #26967

Fix for queue numeric argument conversion #26967

Conversation

bartoszkubicki commented Feb 21, 2020 • edited by m2-assistant bot

Description (*)

Related Pull Requests

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

m2-assistant bot commented Feb 21, 2020

naydav Feb 21, 2020

Choose a reason for hiding this comment

bartoszkubicki Feb 21, 2020 • edited

Choose a reason for hiding this comment

bartoszkubicki Apr 20, 2020

Choose a reason for hiding this comment

sidolov Aug 27, 2020

Choose a reason for hiding this comment

sidolov commented Aug 17, 2020

sidolov Aug 27, 2020

Choose a reason for hiding this comment

bartoszkubicki commented Aug 27, 2020

sidolov commented Aug 27, 2020

sidolov commented Sep 1, 2020

engcom-Foxtrot Oct 12, 2020 • edited

Choose a reason for hiding this comment

bartoszkubicki commented Oct 12, 2020

engcom-Foxtrot commented Oct 15, 2020

engcom-Foxtrot commented Oct 16, 2020

m2-assistant bot commented Oct 24, 2020

bartoszkubicki commented Oct 25, 2020

bartoszkubicki commented Feb 21, 2020 •

edited by m2-assistant bot

bartoszkubicki Feb 21, 2020 •

edited

engcom-Foxtrot Oct 12, 2020 •

edited