Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Api to create customer don't validate payload data and create corrupted record #28064

Closed
GDauer opened this issue Apr 30, 2020 · 12 comments · Fixed by #28903
Closed

Web Api to create customer don't validate payload data and create corrupted record #28064

GDauer opened this issue Apr 30, 2020 · 12 comments · Fixed by #28903
Assignees
Labels
Component: Customer Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@GDauer
Copy link
Contributor

GDauer commented Apr 30, 2020

Preconditions (*)

  1. Magento 2.3.3
  2. PHP 7.2.22
  3. nginx/1.10.3

Steps to reproduce (*)

  1. Send a post request to the endpoint /rest/V1/customers
  2. In the payload send an invalid group_id (by default Magento has the ids: 0, 1, 2, 3)
  3. (optional) Another strange thing is that we can send the request to create a customer without password and the api creates the register.
  4. Example of Request:
    CreateCustomerBug

Expected result (*)

  1. Should throws an Exception informing that the group_id are not found

Actual result (*)

  1. It's creates the client record successfully
  2. The client can't see products or add products to the quote
  3. https://www.loom.com/share/bf9c71c78bd6427b9537285c6064eb80
@m2-assistant
Copy link

m2-assistant bot commented Apr 30, 2020

Hi @GDauer. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@GDauer do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 30, 2020
@shikhamis11 shikhamis11 self-assigned this May 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 1, 2020

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@shikhamis11 shikhamis11 added Component: Customer Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 1, 2020
@ghost ghost unassigned shikhamis11 May 1, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MC-33923 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 1, 2020
@shikhamis11 shikhamis11 added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label May 1, 2020
@ajithkumar-maragathavel
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ajithkumar-maragathavel. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ajithkumar-maragathavel, here is your Magento instance.
Admin access: https://i-28064-2-4-develop.instances.magento-community.engineering/admin_0570
Login: c967ebf9 Password: 2ffe3e105b77
Instance will be terminated in up to 3 hours.

@ajithkumar-maragathavel
Copy link
Contributor

@magento I am working on this

@Den4ik
Copy link
Contributor

Den4ik commented May 4, 2020

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, here is your Magento instance.
Admin access: https://i-28064-2-4-develop.instances.magento-community.engineering/admin_871e
Login: 8101de4d Password: ff5ea4e48ac7
Instance will be terminated in up to 3 hours.

@sdzhepa sdzhepa removed the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label May 4, 2020
@sdzhepa sdzhepa added Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Triage: Ready for Triage Issue is ready to me triaged with Product Manager Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels May 4, 2020
@VladimirZaets VladimirZaets removed the Severity: S1 Affects critical data or functionality and forces users to employ a workaround. label May 6, 2020
@sdzhepa sdzhepa added Triage: Done Has been reviewed and prioritized during Triage with Product Managers and removed Triage: Ready for Triage Issue is ready to me triaged with Product Manager labels May 7, 2020
@engcom-Charlie engcom-Charlie self-assigned this Jun 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2020

Hi @engcom-Charlie. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@magento-engcom-team
Copy link
Contributor

Hi @GDauer. Thank you for your report.
The issue has been fixed in #28903 by @engcom-Charlie in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jul 16, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.3 Indicates original Magento version for the Issue report. label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Archived in project
8 participants