Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on "Purchase Order" cause error in discount section #28208

Closed
vovayatsyuk opened this issue May 13, 2020 · 24 comments
Closed

Click on "Purchase Order" cause error in discount section #28208

vovayatsyuk opened this issue May 13, 2020 · 24 comments
Labels
Component: Checkout Event: dmcdindia2020 Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.3.5p1 Only if reproduced on 2.3.5p1 but not on 2.4-develop Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. stale issue Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@vovayatsyuk
Copy link
Member

Preconditions (*)

  1. Magento 2.3.5

Steps to reproduce (*)

  1. Enable "purchase order" and "check/money" payment methods
  2. Navigate to checkout
  3. Proceed to payment step and expand the discount block section
  4. Change payment to "Purchase order"
  5. An error will be added to the discount sectiton.

Expected result (*)

  1. I expect no errors at all because I just wanted to change payment method.

Actual result (*)

  1. Error is shown

Знімок екрана 2020-05-13 о 16 45 58

Explanation

The issue is caused by the 'setPaymentInformationAction' request added to fix per-payment coupon discount: b6880b2#diff-aa8b012e2fbfb8f3c2904b7ea0504606

Possible Solution

We need some "lightweight" version of savePaymentInformation method that will work with minimum data and will not trigger any errors.

@m2-assistant
Copy link

m2-assistant bot commented May 13, 2020

Hi @vovayatsyuk. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@vovayatsyuk do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ghost ghost added this to Ready for QA in Community Backlog May 13, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 13, 2020
@vovayatsyuk
Copy link
Member Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Magento instance deployment temporary unavailable due to service maintenance.

@sudheers-kensium sudheers-kensium self-assigned this May 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 13, 2020

Hi @sudheers-kensium. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@sudheers-kensium
Copy link
Contributor

Issue is reproduced on Magento 2.3.5 and after few seconds error message is disappearing.

image

@sudheers-kensium sudheers-kensium added Component: Checkout Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels May 13, 2020
@ghost ghost unassigned sudheers-kensium May 13, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog May 13, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 13, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @sudheers-kensium
Thank you for verifying the issue. Based on the provided information internal tickets MC-34290 were created

Issue Available: @sudheers-kensium, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sudheers-kensium sudheers-kensium added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Reproduced on 2.3.5p1 Only if reproduced on 2.3.5p1 but not on 2.4-develop labels May 13, 2020
@CarmineDamore78
Copy link

Issue not reproduced on Magento 2.3.4

@sudheers-kensium
Copy link
Contributor

Issue is reproduced on Magento 2.3.5p1.

@balaji-pinpoint
Copy link

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented May 21, 2020

Hi @balaji-pinpoint! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@balaji-pinpoint
Copy link

@magento I am working on this

@engcom-Alfa engcom-Alfa added the Triage: Ready for Triage Issue is ready to me triaged with Product Manager label Jul 30, 2020
@engcom-Alfa
Copy link
Contributor

The issue is reproducible on fresh 2.4-develop

Peek 2020-08-03 14-22

@engcom-Alfa engcom-Alfa added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 3, 2020
@surabhisrivastava09
Copy link
Member

@magento i am working on this.

@surabhisrivastava09
Copy link
Member

#dmcdindia2020

@ghost ghost unassigned surabhisrivastava09 Nov 4, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in Low Priority Backlog Nov 4, 2020
@m2-community-project m2-community-project bot removed this from Ready for Dev in Community Backlog Nov 4, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.5 Indicates original Magento version for the Issue report. label Nov 13, 2020
@stale
Copy link

stale bot commented Jan 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Jan 29, 2021
@vovayatsyuk
Copy link
Member Author

vovayatsyuk commented Feb 11, 2021

This issue is still relevant.

Additional note: when agreements are enabled you'll see the error about agreements when trying to change the selected payment method. And this time it's not related to the "Purchase Order" method. All methods are affected as well.

image

@stale stale bot removed the stale issue label Feb 11, 2021
@stale
Copy link

stale bot commented Apr 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Apr 28, 2021
@vovayatsyuk
Copy link
Member Author

This issue is still relevant. #28208 (comment)

@stale stale bot removed the stale issue label Apr 28, 2021
@stale
Copy link

stale bot commented Sep 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 28 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Sep 27, 2021
@vovayatsyuk
Copy link
Member Author

.

@hostep
Copy link
Contributor

hostep commented Oct 11, 2021

Issue was confirmed, so stalebot should shut up.

@engcom-Bravo
Copy link
Contributor

Hi @vovayatsyuk,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is no more reproducible.Kindly refer the attached video.

Screen.Recording.2024-05-27.at.15.10.28.mov

We are able to change the payment method.

Hence We are closing this issue.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Checkout Event: dmcdindia2020 Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.3.5p1 Only if reproduced on 2.3.5p1 but not on 2.4-develop Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. stale issue Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Development

No branches or pull requests

10 participants