Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] replaced deprecated addWarning method with addWarningMessage method … #28308

Closed
4 tasks done
ghost opened this issue May 20, 2020 · 2 comments · Fixed by #28264
Closed
4 tasks done

[Issue] replaced deprecated addWarning method with addWarningMessage method … #28308

ghost opened this issue May 20, 2020 · 2 comments · Fixed by #28264
Assignees
@kishorekumarkesavan
Labels
Component: Backend Component: Message Component: Security Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@ghost
Copy link

ghost commented May 20, 2020 •
edited by engcom-Alfa
Loading

This issue is automatically created based on existing pull request: #28264: replaced deprecated addWarning method with addWarningMessage method …

…in Security module

Replace deprecated addWarning method with addWarningMessage method in Magento core security module

Preconditions (*)

  addWarning method is deprecated, to replace the addWarning method with addWarningMessage method in Magento core security module

Steps to reproduce (*)

  1. Logged in to your magento admin panel , go to Store -> Configuration -> Advanced -> Admin -> Security -> Admin Account Sharing -> NO
  2. Logged in to your magento admin panel in a different browsers, in the current browser admin session will be created with the warning message.

Actual Result

N/a

Expected Result

The warning message is shown as previously (expected)

screenshot_60

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@ghost ghost added Component: Security Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels May 20, 2020
@kishorekumarkesavan kishorekumarkesavan mentioned this issue May 20, 2020
Merged
5 tasks
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label May 20, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Jun 12, 2020
@engcom-Alfa engcom-Alfa added Component: Backend Component: Message Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jun 12, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-35142 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Fixed in 2.4.x The issue has been fixed in 2.4-develop branch labels Jun 12, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-backlog[bot]. Thank you for your report.
The issue has been fixed in #28264 by @kishorekumarkesavan in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@ghost ghost added the Progress: done label Jun 13, 2020
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kishorekumarkesavan kishorekumarkesavan

Labels
Component: Backend Component: Message Component: Security Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replaced deprecated addWarning method with addWarningMessage method … kishorekumarkesavan/magento2
3 participants
@magento-engcom-team @engcom-Alfa @kishorekumarkesavan