Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] MFTF: Share wishlist with not valid email address #28377

Closed
ghost opened this issue May 26, 2020 · 3 comments · Fixed by #28330
Closed

[Issue] MFTF: Share wishlist with not valid email address #28377

ghost opened this issue May 26, 2020 · 3 comments · Fixed by #28330
Assignees
@DmitryTsymbal
Labels
Component: Wishlist Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Community Backlog

Comments

@ghost
Copy link

ghost commented May 26, 2020 •
edited by engcom-Alfa
Loading

This issue is automatically created based on existing pull request: #28330: MFTF: Share wishlist with not valid email address

This PR contains MFTF test for Customer's WishList sharing with not valid email addresses.
PR contains refactoring of existed test for wishlist sharing (StorefrontShareWishlistEntityTest)
Deprecated StorefrontCustomerShareWishlistActionGroup due to hardcoded WishList Data Using.
Announced new StorefrontShareCustomerWishlistActionGroup due to best practices.

Preconditions (*)

Steps to reproduce (*)

1 - Login as a Customer
2 - Add product into WishList
3 - Fill in share info emails with invalid emails
4 - Click the "Share WishList" button
5 - Perform Assertions

Expected result (*)

  1. [Screenshots, logs or description]

Actual result (*)

  1. [Screenshots, logs or description]
@ghost ghost added the Component: Wishlist label May 26, 2020
@DmitryTsymbal DmitryTsymbal mentioned this issue May 26, 2020
Merged
1 task
@ghost ghost assigned DmitryTsymbal May 26, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label May 26, 2020
@ghost ghost added this to PR In Progress in Community Backlog May 26, 2020
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels May 27, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Jun 2, 2020
@engcom-Alfa engcom-Alfa added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jun 2, 2020
@ghost ghost removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jun 2, 2020
@ghost
Copy link
Author

ghost commented Jun 2, 2020

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@engcom-Alfa engcom-Alfa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jun 2, 2020
@ghost ghost removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jun 2, 2020
@engcom-Alfa engcom-Alfa moved this from PR In Progress to Ready for QA in Community Backlog Jun 2, 2020
@engcom-Alfa engcom-Alfa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jun 2, 2020
@ghost ghost removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jun 2, 2020
@engcom-Alfa engcom-Alfa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jun 2, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog Jun 2, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 2, 2020
@ghost ghost removed the Progress: ready for QA label Jun 2, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-34804 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Alfa engcom-Alfa moved this from Ready for Dev to PR In Progress in Community Backlog Jun 2, 2020
@sdzhepa sdzhepa added the Triage: Done Has been reviewed and prioritized during Triage with Product Managers label Jun 2, 2020
@slavvka
Copy link
Member

slavvka commented Jun 5, 2020

Hi @m2-backlog[bot]. Thank you for your report.
The issue has been fixed in #28330 by @DmitryTsymbal in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jun 5, 2020
@slavvka slavvka closed this as completed Jun 5, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jun 5, 2020
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitryTsymbal DmitryTsymbal

Labels
Component: Wishlist Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MFTF: Share wishlist with not valid email address DmitryTsymbal/magento2
5 participants
@sdzhepa @slavvka @magento-engcom-team @DmitryTsymbal @engcom-Alfa