Refactoring

magento · May 22, 2020 · fe64579 · fe64579
1 parent 8727fb9
commit fe64579
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 32 deletions.
diff --git a/...ode/Magento/Wishlist/Test/Mftf/ActionGroup/StorefrontCustomerShareWishlistActionGroup.xml b/...ode/Magento/Wishlist/Test/Mftf/ActionGroup/StorefrontCustomerShareWishlistActionGroup.xml
@@ -7,16 +7,17 @@
 -->
 
 <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
-    <actionGroup name="StorefrontCustomerShareWishlistActionGroup">
-        <arguments>
-            <argument name="email" type="string"/>
-            <argument name="message" type="string"/>
-        </arguments>
+        xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="StorefrontCustomerShareWishlistActionGroup" deprecated="Use StorefrontCustomerWishlistShareActionGroup">
+        <!-- Deprecated due to Hardcoded WishList Data Using. 18-19 lines -->
+        <annotations>
+            <description>Shares the Wish List from the Storefront Wish List page. PLEASE NOTE: The details for sharing are Hardcoded using 'Wishlist'.</description>
+        </annotations>
 
         <click selector="{{StorefrontCustomerWishlistProductSection.productShareWishList}}" stepKey="clickMyWishListButton"/>
-        <fillField userInput="{{email}}" selector="{{StorefrontCustomerWishlistShareSection.ProductShareWishlistEmail}}" stepKey="fillEmailsForShare"/>
-        <fillField userInput="{{message}}" selector="{{StorefrontCustomerWishlistShareSection.ProductShareWishlistTextMessage}}" stepKey="fillShareMessage"/>
+        <fillField userInput="{{Wishlist.shareInfo_emails}}" selector="{{StorefrontCustomerWishlistShareSection.ProductShareWishlistEmail}}" stepKey="fillEmailsForShare"/>
+        <fillField userInput="{{Wishlist.shareInfo_message}}" selector="{{StorefrontCustomerWishlistShareSection.ProductShareWishlistTextMessage}}" stepKey="fillShareMessage"/>
         <click selector="{{StorefrontCustomerWishlistShareSection.ProductShareWishlistButton}}" stepKey="sendWishlist"/>
+        <see selector="{{StorefrontCustomerWishlistProductSection.productSuccessShareMessage}}" userInput="Your wish list has been shared." stepKey="successMessage"/>
     </actionGroup>
 </actionGroups>
diff --git a/...o/Wishlist/Test/Mftf/ActionGroup/StorefrontCustomerShareWishlistActionGroupDEPRECATED.xml b/...o/Wishlist/Test/Mftf/ActionGroup/StorefrontCustomerShareWishlistActionGroupDEPRECATED.xml
diff --git a/...ode/Magento/Wishlist/Test/Mftf/ActionGroup/StorefrontShareCustomerWishlistActionGroup.xml b/...ode/Magento/Wishlist/Test/Mftf/ActionGroup/StorefrontShareCustomerWishlistActionGroup.xml
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="StorefrontShareCustomerWishlistActionGroup">
+        <arguments>
+            <argument name="email" type="string"/>
+            <argument name="message" type="string"/>
+        </arguments>
+
+        <click selector="{{StorefrontCustomerWishlistProductSection.productShareWishList}}" stepKey="clickMyWishListButton"/>
+        <fillField userInput="{{email}}" selector="{{StorefrontCustomerWishlistShareSection.ProductShareWishlistEmail}}" stepKey="fillEmailsForShare"/>
+        <fillField userInput="{{message}}" selector="{{StorefrontCustomerWishlistShareSection.ProductShareWishlistTextMessage}}" stepKey="fillShareMessage"/>
+        <click selector="{{StorefrontCustomerWishlistShareSection.ProductShareWishlistButton}}" stepKey="sendWishlist"/>
+    </actionGroup>
+</actionGroups>
diff --git a/app/code/Magento/Wishlist/Test/Mftf/Test/StorefrontShareWishlistEntityTest.xml b/app/code/Magento/Wishlist/Test/Mftf/Test/StorefrontShareWishlistEntityTest.xml
@@ -48,7 +48,7 @@
             <argument name="productVar" value="$createProduct$"/>
         </actionGroup>
 
-        <actionGroup ref="StorefrontCustomerShareWishlistActionGroup" stepKey="shareWishlist">
+        <actionGroup ref="StorefrontShareCustomerWishlistActionGroup" stepKey="shareWishlist">
             <argument name="email" value="{{Wishlist.shareInfo_emails}}"/>
             <argument name="message" value="{{Wishlist.shareInfo_message}}"/>
         </actionGroup>

diff --git a/...e/Magento/Wishlist/Test/Mftf/Test/StorefrontShareWishlistWithNotValidEmailAddressTest.xml b/...e/Magento/Wishlist/Test/Mftf/Test/StorefrontShareWishlistWithNotValidEmailAddressTest.xml
@@ -40,7 +40,7 @@
         <actionGroup ref="StorefrontCustomerAddProductToWishlistActionGroup" stepKey="addToWishlistProduct">
             <argument name="productVar" value="$createProduct$"/>
         </actionGroup>
-        <actionGroup ref="StorefrontCustomerShareWishlistActionGroup" stepKey="shareWishList">
+        <actionGroup ref="StorefrontShareCustomerWishlistActionGroup" stepKey="shareWishList">
             <argument name="email" value="{{notValidEmails.shareInfo_emails}}"/>
             <argument name="message" value="{{notValidEmails.shareInfo_message}}"/>
         </actionGroup>