Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloadable product is available in My Download Products tab after it has been partially refunded #28388

Closed
5 tasks
YaninaPrudnikova opened this issue May 27, 2020 · 11 comments · Fixed by #28413
Closed
5 tasks
Assignees
Labels
Component: Downloadable Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@YaninaPrudnikova
Copy link

YaninaPrudnikova commented May 27, 2020

Preconditions (*)

  1. Magento CE 2.3.5 wih sample data is installed.
  2. Order with a download product and a product, requiring shipping, (e.g. simple product) is created.
  3. The downloadable product is available in My Downloadable Products tab.

Steps to reproduce (*)

  1. Open this order page in Admin.
  2. Perform a partial refund for the downloadable product (the other product is not refunded).
  3. Go to My Downloadable Products tab.

Expected result (*)

  1. Downloadable product cannot be downloaded.

Actual result (*)

  1. Downloadable product still can be downloaded.
    order page
    My DP tab

Additional information

Issue also reproduce on the lates 2.4-develop #28388 (comment)


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented May 27, 2020

Hi @YaninaPrudnikova. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@ghost ghost added this to Ready for QA in Community Backlog May 27, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 27, 2020
@swathishs swathishs self-assigned this May 27, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 27, 2020

Hi @swathishs. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@swathishs
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @swathishs. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @swathishs, here is your Magento instance.
Admin access: https://i-28388-2-4-develop.instances.magento-community.engineering/admin_2f57
Login: 834c9a5f Password: 3933fe214544
Instance will be terminated in up to 3 hours.

@swathishs
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @swathishs. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@swathishs
Copy link

@YaninaPrudnikova: Issue is reproducible in Magento 2.4-develop instance

Please find the attachment below:

  1. Shopping cart:
    image

  2. Downloaded product before invoice:
    image

  3. Order invoiced:
    image

  4. Partially refunded:
    image

  5. Able to download downloaded product:
    image

@swathishs swathishs added Component: Downloadable Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 28, 2020
@ghost ghost unassigned swathishs May 28, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog May 28, 2020
@ghost ghost removed the Progress: ready for QA label May 28, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @swathishs
Thank you for verifying the issue. Based on the provided information internal tickets MC-34710 were created

Issue Available: @swathishs, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 28, 2020
@ProkopovVitaliy
Copy link
Contributor

I will work on this issue.

@ghost ghost assigned ProkopovVitaliy May 28, 2020
@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog May 28, 2020
@sdzhepa sdzhepa added Triage: Ready for Triage Issue is ready to me triaged with Product Manager Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels May 28, 2020
@sdzhepa sdzhepa added Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers and removed Triage: Ready for Triage Issue is ready to me triaged with Product Manager labels Jun 1, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 2, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Sep 2, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.5 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Done (last 30 days) in Community Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Downloadable Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Development

Successfully merging a pull request may close this issue.

5 participants