Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product CSV import error report file missing #28420

Closed
1 of 5 tasks
mischabraam opened this issue May 29, 2020 · 21 comments · Fixed by #28460
Closed
1 of 5 tasks

Product CSV import error report file missing #28420

mischabraam opened this issue May 29, 2020 · 21 comments · Fixed by #28460
Assignees
Labels
Component: Downloadable Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.5-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@mischabraam
Copy link

mischabraam commented May 29, 2020

Preconditions (*)

  1. Magento 2.3.5-p1

Steps to reproduce (*)

  1. Import a product CSV which will generate errors like a not existing path to an image.

Expected result (*)

  1. An error_report.csv file with the errors generated in the import.

Actual result (*)

  1. No file..... the file is generated, but will be removed after the application ends.

The following causes this problem, see my comment in the destructor.
bc06501?diff=split#r39524421

Additional information


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented May 29, 2020

Hi @mischabraam. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@ghost ghost added this to Ready for QA in Community Backlog May 29, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 29, 2020
@swathishs swathishs self-assigned this May 29, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 29, 2020

Hi @swathishs. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@swathishs
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @swathishs. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @swathishs, here is your Magento instance.
Admin access: https://i-28420-2-4-develop.instances.magento-community.engineering/admin_70b5
Login: 014ba51e Password: ccb37a638d04
Instance will be terminated in up to 3 hours.

@swathishs
Copy link

@mischabraam: The issue is reproducible in Magento 2.4-develop instance

Please find the attachment below:

1.Check the data
image
2. After import
image
3. Click on error file
image
Viedo -
eUZmQY2uq2

@mischabraam
Copy link
Author

Yes, I saw the commit I mentioned is also in de 2.4-develop branch.

@swathishs swathishs added Component: Downloadable Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 29, 2020
@ghost ghost unassigned swathishs May 29, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog May 29, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @swathishs
Thank you for verifying the issue. Based on the provided information internal tickets MC-34741 were created

Issue Available: @swathishs, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 29, 2020
@mischabraam
Copy link
Author

Screenshot_2020-05-29_at_12_29_14

Don't know if this helps or not, but see screenshot above.

@engcom-Charlie engcom-Charlie self-assigned this Jun 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 1, 2020

Hi @engcom-Charlie. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost ghost moved this from Ready for Dev to Dev in Progress in Community Backlog Jun 1, 2020
@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog Jun 1, 2020
@sdzhepa sdzhepa added Triage: Ready for Triage Issue is ready to me triaged with Product Manager Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers and removed Triage: Ready for Triage Issue is ready to me triaged with Product Manager labels Jun 1, 2020
@magento-engcom-team
Copy link
Contributor

Hi @mischabraam. Thank you for your report.
The issue has been fixed in #28460 by @engcom-Charlie in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jun 24, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jun 24, 2020
@aheadcreative
Copy link

Same issue - NOT fixed in 2.3.5-p1

2 similar comments
@alejandrocastanon
Copy link

Same issue - NOT fixed in 2.3.5-p1

@aheadcreative
Copy link

Same issue - NOT fixed in 2.3.5-p1

@Lukas713
Copy link

Same issue - NOT fixed in 2.3.5-p2

@RonakParmar
Copy link
Member

I have same issue in 2.3.5-p1. Is there any patch available ?

@camachogfelipe
Copy link

I have same issue in 2.3.5-p2

@jpkileaf
Copy link

jpkileaf commented Nov 2, 2020

is it solved?

@Jeevachezhiyan
Copy link

Is it resolved? Facing same issue in 2.3.5-p1.

I tried this fix in 2.3. But, not working.

bd208cc

@magento-engcom-team magento-engcom-team added the Reported on 2.3.5-p1 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Done (last 30 days) in Community Backlog Nov 13, 2020
@magento-seis10
Copy link

Facing same issue in 2.3.5-p2

@harrigo
Copy link

harrigo commented Feb 25, 2021

Yeah same issue, 2.3.5-p1, the fix however seems great just created a patch like below from the diff and then applied via composer on that import-export module and it worked a treat:

diff --git a/Model/Export/Adapter/Csv.php b//Model/Export/Adapter/Csv.php
index 09b17371ae4e..bc4fcd9218e4 100644
--- a/Model/Export/Adapter/Csv.php
+++ b/Model/Export/Adapter/Csv.php
@@ -54,6 +54,18 @@ public function destruct()
     {
         if (is_object($this->_fileHandler)) {
             $this->_fileHandler->close();
+            $this->resolveDestination();
+        }
+    }
+
+    /**
+     * Remove temporary destination
+     *
+     * @return void
+     */
+    private function resolveDestination(): void
+    {
+        if (strpos($this->_destination, '/') === false) {
             $this->_directoryHandle->delete($this->_destination);
         }
     }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Downloadable Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.5-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Development

Successfully merging a pull request may close this issue.