Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newsletter subscription confirmation email never sent again #28422

Closed
1 of 5 tasks
VincentMarmiesse opened this issue May 29, 2020 · 16 comments · Fixed by #29510
Closed
1 of 5 tasks

Newsletter subscription confirmation email never sent again #28422

VincentMarmiesse opened this issue May 29, 2020 · 16 comments · Fixed by #29510
Assignees
@konarshankar07
Labels
Component: Email Component: Newsletter Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Triage: Ready for Triage Issue is ready to me triaged with Product Manager
Projects
High Priority Backlog

Comments

@VincentMarmiesse
Copy link
Contributor

VincentMarmiesse commented May 29, 2020 •
edited by engcom-Alfa

Preconditions (*)

  1. Magento 2.4-develop

Steps to reproduce (*)

  1. Enable newsletter subscription confirmation ("Need to Confirm" option)
  2. Log in with an account which is not subscribed to the newsletter
  3. Subscribe to the newsletter from My account > Newsletter Subscription
  4. An email asking for subscription confirmation is received.
  5. Imagine the user does not confirm, deletes the email, forgets it or anything else, but he does not confirm his newsletter subscription
  6. He comes back some time later and wants to subscribe to the newsletter, so he does the process again
  7. Subscribe to the newsletter from My account > Newsletter Subscription

Expected result (*)

  1. The confirmation email is sent again

Actual result (*)

  1. The confirmation email is never sent again.

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented May 29, 2020

Hi @VincentMarmiesse. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

@ghost ghost added this to Ready for QA in Community Backlog May 29, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 29, 2020
@VincentMarmiesse
Copy link
Contributor Author

@magento give me 2.3.5-p1 instance

@magento-engcom-team
Copy link
Contributor

Hi @VincentMarmiesse. Thank you for your request. I'm working on Magento 2.3.5-p1 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @VincentMarmiesse, here is your Magento instance.
Admin access: https://i-28422-2-3-5-p1.instances.magento-community.engineering/admin_0ac6
Login: a2fc3d31 Password: 07b624bcd9fb
Instance will be terminated in up to 3 hours.

@VincentMarmiesse
Copy link
Contributor Author

Test instance does not seem to send any email so I can't test it.

@sambath1293 sambath1293 self-assigned this May 29, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 29, 2020

Hi @sambath1293. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@sambath1293
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sambath1293. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sambath1293, here is your Magento instance.
Admin access: https://i-28422-2-4-develop.instances.magento-community.engineering/admin_44da
Login: 4430e10d Password: a648179ed92c
Instance will be terminated in up to 3 hours.

@sambath1293 sambath1293 removed their assignment Aug 4, 2020
@engcom-Alfa engcom-Alfa self-assigned this Aug 6, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2020

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Alfa engcom-Alfa added Component: Email Component: Newsletter Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Ready for Triage Issue is ready to me triaged with Product Manager Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 6, 2020
@ghost ghost unassigned engcom-Alfa Aug 6, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-36520 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 6, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog Aug 6, 2020
@konarshankar07
Copy link
Contributor

@magento I'm working on this

@konarshankar07
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @konarshankar07. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @konarshankar07, here is your Magento instance.
Admin access: https://i-28422-2-4-develop.instances.magento-community.engineering/admin_27fe
Login: 17bddc17 Password: 99f245bab3d8
Instance will be terminated in up to 3 hours.

@konarshankar07 konarshankar07 mentioned this issue Aug 13, 2020
Merged
4 tasks
@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog Aug 13, 2020
@sidolov sidolov added Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels Aug 13, 2020
@ghost ghost moved this from PR In Progress to Ready for Dev in Community Backlog Aug 21, 2020
@magento-engcom-team
Copy link
Contributor

Hi @VincentMarmiesse. Thank you for your report.
The issue has been fixed in #29510 by @konarshankar07 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Aug 24, 2020
@ghost ghost moved this from Ready for Dev to Done (last 30 days) in Community Backlog Aug 24, 2020
magento-engcom-team added a commit that referenced this issue Aug 24, 2020
@magento-engcom-team
ENGCOM-8034: #28422 :- Newsletter subscription confirmation email nev…
ec8a262 
…er sent again #29510

 - Merge Pull Request #29510 from konarshankar07/magento2:newsletter-confirmation-email--task-28422
 - Merged commits:
   1. 1a7c8cd
   2. 6e53e0d
   3. ea584f9
   4. ab3db16
magento-engcom-team pushed a commit that referenced this issue Aug 24, 2020
@sidolov
ENGCOM-8034: #28422 :- Newsletter subscription confirmation email nev…
9de03f5 
…er sent again #29510
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Done (last 30 days) in Community Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konarshankar07 konarshankar07

Labels
Component: Email Component: Newsletter Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Triage: Ready for Triage Issue is ready to me triaged with Product Manager
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#28422 :- Newsletter subscription confirmation email never sent again konarshankar07/magento2
6 participants
@VincentMarmiesse @sidolov @magento-engcom-team @konarshankar07 @engcom-Alfa @sambath1293