Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all files are pre-compiled #2888

Closed
vesan-83 opened this issue Jan 5, 2016 · 4 comments
Closed

Not all files are pre-compiled #2888

vesan-83 opened this issue Jan 5, 2016 · 4 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@vesan-83
Copy link

vesan-83 commented Jan 5, 2016

After setup:di:compile, at least, following files still are generated at run-time

  • var/generation/Magento/Framework/Message/Session/Proxy.php
  • var/generation/Magento/Framework/Reflection/ExtensionAttributesProcessor/Proxy.php
  • var/generation/Magento/Framework/View/Layout/File/Collector/Aggregated/Proxy.php

This gives 2 issues

  • It doesn't allow to restrict web-server to write PHP files in order to provide a hight level of security on production server
  • It's impossible to prepare integral package for production

Could it be fixed?

@melnikovi
Copy link
Member

Thank you for reporting this issue. JIRA ticket created MAGETWO-47639

@astorm
Copy link

astorm commented Jan 5, 2016

@vesan-83 Not a Magento core team member here, so I can't help you directly but if you could provide a few more details it might help @melnikovi and the core team track this one down.

  1. Does setup:di:compile finish running? Can you include its output here?
  2. Is your system actually running in production mode when the classes are generated?
  3. Which pages are you loading and/or commands are you running to trigger generation of those classes. (be specific, even if you think it's a general problem)

That sort of information will help the core team track down the problem.

@vesan-83
Copy link
Author

vesan-83 commented Jan 6, 2016

  1. Yes, see di-compile.log and di-compile.png
  2. Yes, see .htaccess from pub folder
  3. Home page, steps:
    • rm -rf var/cache var/di var/generation var/page_cache var/view_preprocessed pub/static/*
    • bin/magento setup:di:compile
    • bin/magento setup:static-content:deploy
    • find var/generation -type f (see files-after-compile.txt)
    • visit home page
    • find var/generation -type f (see files-after-home-page.txt, it shows 9 new files)

https://github.com/magento/magento2/files/79596/attachments.zip

magento-team pushed a commit that referenced this issue Jan 13, 2016
magento-team pushed a commit that referenced this issue Jan 13, 2016
magento-team pushed a commit that referenced this issue Jan 13, 2016
magento-team pushed a commit that referenced this issue Jan 13, 2016
@victorgugo victorgugo added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 14, 2016
okorshenko pushed a commit that referenced this issue Jan 20, 2016
okorshenko pushed a commit that referenced this issue Jan 20, 2016
okorshenko pushed a commit that referenced this issue Jan 20, 2016
okorshenko pushed a commit that referenced this issue Jan 20, 2016
@vesan-83
Copy link
Author

The issue is fixed,
Thanks

@sshrewz sshrewz closed this as completed Feb 26, 2016
magento-engcom-team pushed a commit that referenced this issue Jul 24, 2018
Tasks:
 - MAGETWO-93669 [Forwardport] Implement parallelization for Category Product Indexer
 - MAGETWO-93671 [Forwardport] Implement parallelization for Search Indexer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

6 participants