New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PHP 8.0 #28897
Comments
Hi @rvitaliy. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
|
Hi @swathishs. Thank you for working on this issue.
|
@rvitaliy : Thank you for your report. For GitHub issue tracker is for Magento core technical issues only |
This is a technical problem, in November we could not use the new version of PHP because your platform will be obsolete again. I see that time passes but your bad habits don't change. see #27227 Good job, bya! |
Hello @rvitaliy Thank you for your question! Let me please provide some clarification. For now, I have not heard during internal meetings and discuss any future plans for PHP 8.0 support. But I am sure as soon as Magneto will have any roadmap/plans for this track, it will be announced through public media channels. This public GitHub issue tracker is aimed at issues/bugs/improvements that ready to work - something that can be taken by any community member and fixing(creating PR). This issue report looks like an open question that should be discussed. I would recommend to raise this topic/question and discuss in the next channels first:
Also, I do not see any reason to keep this issue report open. |
I think Magento LTS (OpenMage) will support PHP 8 first as it's more active. Or just use WooCommerce instead. M2 updates are kinda slow and until today PHP 7.4.4 is still not supported. O___O. PHP 7.3 EOL is in 4 months (December 6, 2020). |
Hi there, let me provide additional input here. We are seriously considering PHP 8.0 support for Magento, and some of the features would be especially handy for Magento. Currently, we support PHP 7.4 / 7.3, and taking into account that active support of 7.3 will end soon, we switched our CI/CD infrastructure towards 7.4.* Usually in Magento when we release a major version of the platform we keep supporting throughout all patch releases (in the scope of that major version) all the PHP versions which were actively supported at the time when Magento major release was out. This is done to prevent possible BiC for patch release upgrades. Also, we separate "support" and "compatibility" in terms of Magento. So, if we would find a way to introduce "Compatibility" of Magento 2.4 with PHP 8.0 - we would definitely do this. Moreover, we really encourage you to help us finding a way of doing this. Thus, all the PRs which provide this compatibility for Magento 2.4 will have a very high priority for us, and we will consider them thoroughly. @bryanveIoso I did not hear anything about problems with PHP 7.4.4 - could you provide more background here? |
@maghamed: @bryanveIoso commented on 7 July, so before Magento 2.4.0 was released (20 July), at that time no Magento versions were out with support for PHP 7.4 😉 Thanks for the extra information though! |
I will re-open this issue, as it wasn't resolved yet, there is no php 8 support. |
Has anyone here already tried to setup a preload feature from 7.4 ? |
Update: we already have php 8.0 beta3, would be good at least to try run magento on it. @ilnytskyi no, I don't, but would be good to see some info about it! |
I've tested PHP 8 performance on Magento 2 and compare the results with PHP 7.3. Here it is https://onilab.com/blog/php-7-vs-php-8/ The bottomline: the PHP 8 JIT is far from being useful in terms of improving the Magento 2 web application performance. However, it is fair to say that the feature perfectly copes with its tasks on simple code. |
@Alex88-hub I think it's a real shame that we can't take advantage of them yet. |
FYI I just published a new Docker image for PHP 8.0 at https://github.com/markshust/docker-magento/tree/master/images/php/8.0 You can use the standard docker-compose setup at https://github.com/markshust/docker-magento and install Magento as usual. After it's installed, update the I hope this helps out those who want to test Magento 2 on PHP 8. It should be very easy & simple to get an instance up & running that is easily replicable to diagnose/test issues. |
I still feel like they may wait for Magento 3... Typing everything is a lot of work and the core codebase is sprawling at this point. Plus PWA Studio and Venia is coming... so any PHP they static-type for the frontend will be wasted. |
@EmperorKonstantin Rector would probably help with that. |
@JosephLeedy I'm not familiar with Rector, but I also hope that they use TypeScript in Magento 3 PWA Studio. |
They are working on it on this branch should you be curious: https://github.com/magento/magento2/tree/php8-develop Tickets around this can be seen over here: https://github.com/magento/magento2/projects/31 |
@hostep You're a champ! Yay! I see types! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions! |
This definitely should be open, as magento already have php 8 project. |
don't forget to allow php 8.1 🙏🚀 |
hi everyone, |
Closed, because Magento2 is compatibility with PHP 8.0 on |
Out of curiosity: Magento 2.4.4 will ship with support for PHP 8.1, but will it also still be compatible with older versions of PHP, like 8.0 and 7.4? Based on the commit mentioned above, I would assume it will? |
Hi @hostep, you can find information about supported versions on the DevDocs System Requirements page |
Hi, PHP 8.0 is planned for release in november 2020. It would be nice to see Magento 2.4 support it on release date.
Today the alpha1 is already available, so we can start to test it in CI tests.
https://wiki.php.net/todo/php80
https://twitter.com/official_php/status/1276198231714783232?s=20
The text was updated successfully, but these errors were encountered: