Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login as Customer storefront banner is not sticky #29354

Closed
1 task
mbrinton01 opened this issue Jul 31, 2020 · 7 comments · Fixed by #29415
Closed
1 task

Login as Customer storefront banner is not sticky #29354

mbrinton01 opened this issue Jul 31, 2020 · 7 comments · Fixed by #29415
Assignees
Labels
Component: Login Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Project: Login as Customer Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.

Comments

@mbrinton01
Copy link

Preconditions (*)

Magento 2.4.0

Steps to reproduce (*)

  1. Enable Login as Customer
  2. Login as Customer to the Storefront (view detail page for a customer in the admin panel, click "Login as Customer" in header)

Expected result (*)

  1. Persistent banner appears at top of screen
  2. Per original UX design in https://xd.adobe.com/view/7c1347fc-d229-4afc-5ee7-1c53bdaec588-0a22/, banner is "sticky" and remains at top of screen when user scrolls down

Actual result (*)

  1. Persistent banner appears at top of screen
  2. Banner is not "sticky." When user scrolls down on the page, banner scrolls out of view.

Actual result shown in video:
login as customer header.mov.zip


  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
@m2-assistant
Copy link

m2-assistant bot commented Jul 31, 2020

Hi @mbrinton01. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Ready for QA in Community Backlog Jul 31, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 31, 2020
@mbrinton01
Copy link
Author

FYI @sdzhepa

@mbrinton01
Copy link
Author

FYI @smuletf

@sdzhepa sdzhepa added this to Ready for Dev in Login as Customer - Backlog Jul 31, 2020
@sdzhepa sdzhepa removed this from Ready for QA in Community Backlog Jul 31, 2020
@sdzhepa sdzhepa added Project: Login as Customer Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 31, 2020
@naydav naydav moved this from Ready for Dev to Good First Issue in Login as Customer - Backlog Aug 5, 2020
@konarshankar07
Copy link
Contributor

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Aug 11, 2020

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash krishprakash added Component: Login Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Aug 11, 2020
@ghost ghost unassigned krishprakash Aug 11, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-36609 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 11, 2020
@sdzhepa sdzhepa removed this from PR In Progress in Community Backlog Aug 12, 2020
@naydav naydav moved this from Good First Issue to PR In Progress in Login as Customer - Backlog Aug 12, 2020
@ghost ghost added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Sep 14, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 14, 2020
Login as Customer - Backlog automation moved this from PR In Progress to Done (last 30 days) Sep 14, 2020
@ghost ghost added this to Done (last 30 days) in Community Backlog Sep 14, 2020
magento-engcom-team added a commit that referenced this issue Sep 14, 2020
…cky #29415

 - Merge Pull Request #29415 from konarshankar07/magento2:lac-sticky-banner--task-29354
 - Merged commits:
   1. 4f2d8de
   2. 43cca51
   3. 00b3ff2
   4. 804ed71
   5. c0ca7cd
   6. b35d9dc
   7. 425113c
   8. 58b78f6
   9. debeec2
   10. 2aca78a
   11. c3d57cd
   12. eca27c7
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Done (last 30 days) in Login as Customer - Backlog Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Done (last 30 days) in Community Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Login Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Project: Login as Customer Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Development

Successfully merging a pull request may close this issue.

5 participants