Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unions in GQL #29425

Closed
magento-engcom-team opened this issue Aug 6, 2020 · 2 comments · Fixed by #29426
Closed

Implement unions in GQL #29425

magento-engcom-team opened this issue Aug 6, 2020 · 2 comments · Fixed by #29426
Assignees
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Aug 6, 2020

Implement unions in graphql

As a developer I want to be able to implement unions in the Magento graphql schema language following the specification https://spec.graphql.org/June2018/#sec-Unions

Acceptance criteria:
allow a syntax like the following:

union CompanyStructureEntity 
@doc(description: "some kind of union") 
@typeResolver(class: "Magento\\Module\\Resolver")  =
    CompanyTeam | Customer
{code}



Allow and resolve a query with proper types representing each type in union like the following:
{code:java}
{
  company {
    structure {
      items {
        id
        parent_id
        entity {
          __typename
          ... on Customer {
            firstname
            lastname
          }
          ... on CompanyTeam {
            name
          }
        }
      }
    }
  }
}
@magento-engcom-team magento-engcom-team added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Aug 6, 2020
@magento-engcom-team
Copy link
Contributor Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-36456

@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Ready for Dev in Community Backlog Aug 6, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 6, 2020
@ghost ghost assigned cpartica Aug 6, 2020
@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog Aug 6, 2020
@ghost ghost moved this from PR In Progress to Ready for Dev in Community Backlog Aug 6, 2020
@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog Aug 6, 2020
@ghost ghost moved this from PR In Progress to Dev in Progress in Community Backlog Aug 6, 2020
@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog Aug 18, 2020
@ghost ghost moved this from PR In Progress to Dev in Progress in Community Backlog Sep 2, 2020
@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog Sep 2, 2020
@ghost ghost moved this from PR In Progress to Ready for Dev in Community Backlog Sep 2, 2020
@ghost ghost moved this from Ready for Dev to Dev in Progress in Community Backlog Sep 2, 2020
@ghost ghost moved this from Dev in Progress to Done (last 30 days) in Community Backlog Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Development

Successfully merging a pull request may close this issue.

2 participants