Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC-36456: union implementation #29426

Merged
merged 13 commits into from
Sep 2, 2020
Merged

MC-36456: union implementation #29426

merged 13 commits into from
Sep 2, 2020

Conversation

cpartica
Copy link
Contributor

@cpartica cpartica commented Aug 6, 2020

Description (*)

Related Pull Requests

https://github.com/magento/partners-magento2b2b/pull/216
https://github.com/magento/partners-magento2-infrastructure/pull/30

Fixed Issues (if relevant)

  1. Fixes Implement unions in GQL #29425

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2020

Hi @cpartica. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@gallyamov gallyamov linked an issue Aug 13, 2020 that may be closed by this pull request
@cpartica cpartica changed the base branch from 2.4-develop to 2.4 August 18, 2020 21:20
@cpartica cpartica changed the base branch from 2.4 to 2.4-develop August 18, 2020 21:21
@gallyamov gallyamov linked an issue Aug 24, 2020 that may be closed by this pull request
@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Aug 26, 2020
@ghost ghost moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Aug 31, 2020
@ghost ghost moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Aug 31, 2020
@magento-engcom-team magento-engcom-team merged commit d3c5778 into 2.4-develop Sep 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @cpartica, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 2, 2020
@cpartica cpartica deleted the MC-36456 branch September 4, 2020 14:34
@ghost ghost moved this from Recently Merged to Changes Requested in Pull Requests Dashboard Sep 15, 2020
@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Oct 1, 2020
@ghost ghost moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Oct 1, 2020
@ghost ghost moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Oct 1, 2020
@sidolov sidolov moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

Implement unions in GQL B2B Company mutations - Update company hierarchy B2B Company Credit Queries
3 participants