Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI : Time field element in admin #29496

Closed
1 of 5 tasks
sankalpshekhar opened this issue Aug 12, 2020 · 4 comments · Fixed by #29511
Closed
1 of 5 tasks

UI : Time field element in admin #29496

sankalpshekhar opened this issue Aug 12, 2020 · 4 comments · Fixed by #29511
Assignees
@konarshankar07
Labels
Component: Sitemap Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Low Priority Backlog

Comments

@sankalpshekhar
Copy link
Contributor

sankalpshekhar commented Aug 12, 2020 •
edited
Loading

The CSS class for limited width doesn't gets applied after CSP port.

Tested on :

  1. Google Chrome : Version 84.0.4147.125 (64-bit)
  2. Firefox : 79.0 (64-bit)

Preconditions (*)

  1. Magento 2.4 Installed with Sample data

Steps to reproduce (*)

  1. Install M2.4.0 with Sample Data
  2. Login to Admin/Backend.
  3. Navigate to following path Store > Configuration > Catalog > XML Sitemap > Generation Settings
  4. Switch the value on 'Enabled' field to 'Yes'

Expected result (*)

image

Actual result (*)

image

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Aug 12, 2020

Hi @sankalpshekhar. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Ready for QA in Community Backlog Aug 12, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 12, 2020
@sdzhepa sdzhepa added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Sitemap Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 12, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog Aug 12, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @sdzhepa
Thank you for verifying the issue. Based on the provided information internal tickets MC-36669 were created

Issue Available: @sdzhepa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 12, 2020
@konarshankar07
Copy link
Contributor

@magento I'm working on this

@konarshankar07 konarshankar07 mentioned this issue Aug 13, 2020
Merged
4 tasks
@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog Aug 13, 2020
@ghost ghost added Progress: PR in progress Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. and removed Progress: ready for dev Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. labels Aug 13, 2020
@ghost ghost moved this from PR In Progress to Ready for Dev in Community Backlog Aug 17, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Aug 19, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sankalpshekhar. Thank you for your report.
The issue has been fixed in #29511 by @konarshankar07 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@ghost ghost moved this from Ready for Dev to Done (last 30 days) in Community Backlog Aug 19, 2020
@ghost ghost removed the Progress: ready for dev label Aug 19, 2020
@ghost ghost added the Progress: done label Aug 19, 2020
magento-engcom-team added a commit that referenced this issue Aug 19, 2020
@magento-engcom-team
ENGCOM-8007: #29496 :- UI : Time field element in admin #29511
575fdf3 
 - Merge Pull Request #29511 from konarshankar07/magento2:ui-fix-for-time-component--task-29496
 - Merged commits:
   1. 23b5a24
   2. 3723b61
magento-engcom-team pushed a commit that referenced this issue Aug 19, 2020
@gabrieldagama
ENGCOM-8007: #29496 :- UI : Time field element in admin #29511
ed11ecd
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Done (last 30 days) in Community Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konarshankar07 konarshankar07

Labels
Component: Sitemap Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Low Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#29496 :- UI : Time field element in admin konarshankar07/magento2
4 participants
@sankalpshekhar @sdzhepa @magento-engcom-team @konarshankar07