Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] System configuration Validation #29502

Closed
4 tasks
m2-assistant bot opened this issue Aug 12, 2020 · 4 comments
Closed
4 tasks

[Issue] System configuration Validation #29502

m2-assistant bot opened this issue Aug 12, 2020 · 4 comments
Labels
Component: Integration Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 12, 2020 •
edited by engcom-Oscar
Loading

This issue is automatically created based on existing pull request: #29486: System configuration Validation

Description (*)

This field should be save empty, but incorrect validation was applied. Because of that, admin user couldn't save the empty value.

Preconditions:

  1. Base Magento 2.4-develop installed.

Steps to reproduce:

  1. Log in in the admin area.
  2. Go to Stores -> Configurations -> Services -> OAuth -> Access Token Expiration.
  3. Empty 'Customer Token Lifetime (hours)' field and save config.
  4. Empty 'Admin Token Lifetime (hours)' field and save config.

Expected result:

Config saved successfully.

Actual result:

Config is not saved. Incorrect validation applied.

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • All new or changed code is covered with unit/integration tests (if applicable)
@ejaz-alam ejaz-alam mentioned this issue Aug 12, 2020
Merged
5 tasks
@ghost ghost added this to Ready for QA in Community Backlog Aug 12, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 12, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Aug 12, 2020
@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 12, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Aug 31, 2020
@engcom-Oscar engcom-Oscar added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 31, 2020
@magento-engcom-team
Copy link
Contributor

@engcom-Oscar Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 31, 2020
@ghost ghost moved this from PR In Progress to Ready for QA in Community Backlog Aug 31, 2020
@engcom-Oscar engcom-Oscar added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 31, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog Aug 31, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 31, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-37226 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Oscar engcom-Oscar moved this from Ready for Dev to PR In Progress in Community Backlog Aug 31, 2020
@m2-community-project m2-community-project bot added this to Ready for Development in Low Priority Backlog Sep 4, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in Low Priority Backlog Sep 4, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for dev labels Sep 4, 2020
@magento-engcom-team magento-engcom-team added Progress: ready for dev and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 4, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Sep 4, 2020
@engcom-Oscar
Copy link

Dublicate #29487

@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Sep 14, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #29486 by @ejaz-alam in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 19, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Done (last 30 days) in Community Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Integration Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sidolov @magento-engcom-team @engcom-Oscar