-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System configuration Validation for Customer/Admin Token life time #29486
Conversation
This field should be save empty, but incorrect validation was applied. Because of that, admin user couldn't save the empty value.
Hi @aliejaz55. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @aliejaz55. Could you check the same issue for the admin token lifetime, please? Also, according to the definition of done, all changes should be covered by autotests. Could I ask you to create a simple MFTF test for this case. The idea of this test is to go to the corresponding settings tab in the admin panel, leave the token lifetime value empty, save the settings and make sure that no error appears. There's a documentation of the MFTF framework itself. You can also check some examples from the recently merged PRs: https://github.com/magento/magento2/pull/27371/files And one more link for the best practices https://github.com/magento/magento-functional-tests-migration/wiki/Best-practices Thank you! |
@magento create issue |
@rogyar for admin token, it has the same issue. I am working on it. Will be resolved soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aliejaz55. Thank you for collaboration. Do you have some updates regarding test coverage? If you need some help on it, please tell us
@magento run all tests |
Yes @VladimirZaets please guide me on this. I have searched about MFTF, but it looks tbat I have to setup all my system for this. Please tell any middle way, that I can use now and in future pull requests. |
Removed invalid "Required Validation" for both admin token and customer token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogyar please check this, removed required validation for admin token. Looking for some help in MFTF. That can also help me for future contribution.
@aliejaz55 here is you can find the documentation, how to setup mftf framework locally and how to run tests. If you will have more specific questions, feel free to ask |
@aliejaz55 |
f1bf77c
to
459fc23
Compare
Hi @sidolov, thank you for the review. |
@magento run all tests |
Hi @ejaz-alam, thank you for your contribution! |
@magento-engcom-team why the bug fix award removed? |
Description (*)
This field should be save empty, but incorrect validation was applied. Because of that, admin user couldn't save the empty value.
Manual testing scenarios (*)
Without the fix
Log in in the admin area
Go to Stores -> Configurations -> Services -> OAuth.
Save Customer Token Lifetime (hours) field without the value/empty.
Save Admin Token Lifetime (hours) field without the value/empty.
Did not saved the configuration without the integer value.
With the fix
Log in in the admin area
Go to Stores -> Configurations -> Services -> OAuth.
Save Customer Token Lifetime (hours) field without the value/empty.
Save Admin Token Lifetime (hours) field without the value/empty.
Configuration saved as mentioned in note comment.
Contribution checklist (*)
Resolved issues: