Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Moving admin export form to Ui components #29587

Closed
m2-assistant bot opened this issue Aug 17, 2020 · 2 comments · May be fixed by #28188
Closed

[Issue] Moving admin export form to Ui components #29587

m2-assistant bot opened this issue Aug 17, 2020 · 2 comments · May be fixed by #28188
Assignees
Labels
Component: Catalog Component: CatalogImportExport Component: ImportExport Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: needs update Additional information is require, waiting for response Priority: P3 May be fixed according to the position in the backlog. Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2020

This issue is automatically created based on existing pull request: #28188: Moving admin export form to Ui components


Description

Admin export form (System > Export) has been moved from blocks to Ui components.

The Pull Request adds the following Ui components:

  1. Magento_ImportExport::view/adminhtml/ui_component/export_form.xml
  2. Magento_ImportExport::view/adminhtml/ui_component/export_filter_grid.xml

Manual testing scenarios

  1. Go to the admin export page - System > Export
  2. Make sure all elements of the Ui form are correctly loaded, there are no errors in the console
  3. Choose Entity Type = Products, make sure grid with the product attributes is loaded without issues
  4. Check the sort and filter features of the grid - all should be fine there
  5. Export products through the button Continue below the grid, make sure the export was successful

Notes

  • All old php classes/layouts/phtml templates were marked as deprecated
  • Broken mftf selectors were fixed to make tests green
  • All new php classes were covered by unit tests
@ghost ghost added this to Ready for QA in Community Backlog Aug 17, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Aug 17, 2020
@ghost ghost added Progress: PR in progress Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Progress: ready for QA labels Aug 17, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 24, 2020
@m2-community-project m2-community-project bot added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Sep 24, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 24, 2020
@engcom-Bravo
Copy link
Contributor

Hi @elevinskii,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Manual testing scenarios

  • Go to the admin export page - System > Export
  • Make sure all elements of the Ui form are correctly loaded, there are no errors in the console
  • Choose Entity Type = Products, make sure grid with the product attributes is loaded without issues
  • Check the sort and filter features of the grid - all should be fine there
  • Export products through the button Continue below the grid, make sure the export was successful

Screenshot from 2024-03-04 16-00-44

We are able to export the related product CSV file.

Kindly recheck the issue in Latest Magento 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Mar 4, 2024
@m2-community-project m2-community-project bot removed this from PR In Progress in Community Backlog Mar 4, 2024
@m2-community-project m2-community-project bot added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Mar 4, 2024
@engcom-Bravo
Copy link
Contributor

Hi @elevinskii,

We have noticed that this issue has not been updated since long time.
Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Low Priority Backlog May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Component: CatalogImportExport Component: ImportExport Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: needs update Additional information is require, waiting for response Priority: P3 May be fixed according to the position in the backlog. Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants