Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving admin export form to Ui components #28188

Open
wants to merge 35 commits into
base: 2.4-develop
Choose a base branch
from
Open

Moving admin export form to Ui components #28188

wants to merge 35 commits into from

Conversation

elevinskii
Copy link
Member

@elevinskii elevinskii commented May 11, 2020 •
edited by m2-assistant bot

Description

Admin export form (System > Export) has been moved from blocks to Ui components.

The Pull Request adds the following Ui components:

  1. Magento_ImportExport::view/adminhtml/ui_component/export_form.xml
  2. Magento_ImportExport::view/adminhtml/ui_component/export_filter_grid.xml

Manual testing scenarios

  1. Go to the admin export page - System > Export
  2. Make sure all elements of the Ui form are correctly loaded, there are no errors in the console
  3. Choose Entity Type = Products, make sure grid with the product attributes is loaded without issues
  4. Check the sort and filter features of the grid - all should be fine there
  5. Export products through the button Continue below the grid, make sure the export was successful

Notes

  • All old php classes/layouts/phtml templates were marked as deprecated
  • Broken mftf selectors were fixed to make tests green
  • All new php classes were covered by unit tests

Resolved issues:

  1. resolves [Issue] Moving admin export form to Ui components #29587: Moving admin export form to Ui components

@elevinskii
Added simple data provider for new Ui grid on export page
576ec20
@elevinskii
Added Ui grid to filter eav attributes on export page
7d058b3
@elevinskii
Added custom template for admin export grid
f137547
@elevinskii
"Exclude" column on admin export grid
736ee03
@elevinskii
Toolbar for admin export grid
6eef1cd
@elevinskii
Filter entries on admin export grid
39f6504
@elevinskii
Fixed issue with drag-and-drop columns on export grid
4cc6fef
@elevinskii
Filter by inputs on export grid
5412c4e
@elevinskii
Filter by selects on export grid
e8854e9
@elevinskii
Filter by multiselects on export grid
5070e02
@elevinskii
Refactored filters on export grid
cbf1090
@elevinskii
Filter by range values on export grid
a30cf09
@elevinskii
Created Ui export form
edacef8
@elevinskii
Insert listing of attributes to export form
f81e64f
@elevinskii
Show attributes for required entity on export form
89990c5
@elevinskii
Final replacement export form by Ui component
8b8100e
@elevinskii
Merge branch '2.4-develop' into admin-export-filter-ui-grid
ecbd2b7
@elevinskii
Adjusted mftf selectors according new functionality on export form
11b82d1
@elevinskii
Deprecated old files after moving to Ui components
37d8f5a
@elevinskii
Simple unit test for export form data provider
33ec8af
@elevinskii
Unit test for export grid data provider
b4b3876
@elevinskii
Unit test for filter column on export page
7370902
@m2-assistant
Copy link

m2-assistant bot commented May 11, 2020

Hi @elevinskii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard May 11, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

1 similar comment
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@elevinskii
Copy link
Member Author

@engcom-Charlie Thank you very much to keep things moving!

@engcom-Oscar engcom-Oscar removed their assignment Oct 5, 2020
@engcom-Charlie engcom-Charlie moved this from Extended Testing (optional) to Pending Review in Pull Requests Dashboard Oct 5, 2020
@elevinskii
Copy link
Member Author

Hello @sidolov

Could we increase the ImportExport version to fix the failed test?
Any help would be really appreciated, thanks.

@sidolov
Copy link
Contributor

sidolov commented Jan 4, 2021

Hi @elevinskii ! The fail not about the module version, it's failed because the blocks were removed. I suggest revert blocks removal and just deprecate them with an explanation in the comment.

@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Mar 4, 2024
@engcom-Delta
Copy link
Contributor

@elevinskii , Thanks for your contribution. Please remove the conflicts on the PR to move forward on this

engcom-Delta
engcom-Delta requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@engcom-Delta engcom-Delta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the conflicts on the PR to move forward on this

@m2-community-project m2-community-project bot moved this from Ready for Testing to Changes Requested in Pull Requests Dashboard Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Delta engcom-Delta engcom-Delta requested changes

@sidolov sidolov Awaiting requested review from sidolov

Assignees

@sidolov sidolov

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: advanced Award: complex Component: Catalog Component: CatalogImportExport Component: ImportExport Priority: P3 May be fixed according to the position in the backlog. Progress: needs update Release Line: 2.4 Risk: medium Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Changes Requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Moving admin export form to Ui components
6 participants
@elevinskii @sidolov @engcom-Oscar @engcom-Delta @engcom-Charlie @magento-engcom-team