[Issue] Fix SQL query quoting/casting when type is passed to where function

[m2-assistant]

This issue is automatically created based on existing pull request: #27980: Fix SQL query quoting/casting when type is passed to where function

---

Framework/DB/Select where function doesn't handle the "type" correctly.

Preconditions (*)

The $type variable can be both string or int, so before comparing it to
'TYPE_CONDITION' string it has to be casted to avoid comparing integer zero
with string (0 == 'TYPE_CONDITION') which will wrongly return true,
and remove the information about type.

Pass type provided to where function down the chain to allow automatic
casting of arrays of values e.g. to int.

This fixes following cases:
1)
$select-->where('attr_table.store_id IN (?)', $storeIds, Zend_Db::INT_TYPE);
2)
$select-->where('attr_table.store_id = ?', $storeId, Zend_Db::INT_TYPE);
In both cases now passed value is correctly casted to int
(either single value, or each value from array)

Related Pull Requests

Fixed Issues (if relevant)

Steps to reproduce:

1. Make custom select like
   $select->from(['catalog_product_entity'], '*')->where('entity_id in (?)', ['1', 2, 3], \Zend_Db::INT_TYPE);
2. Check sql
   $select->__toString()

Expected result (*)

SELECT catalog_product_entity.* FROM catalog_product_entity WHERE (entity_id in (1, 2, 3));

Actual result (*)

SELECT catalog_product_entity.* FROM catalog_product_entity WHERE (entity_id in ('1', 2, 3));

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[magento-engcom-team]

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-37711 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[gabrieldagama]

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #27980 by @tmotyl in 2.4-develop branch
Related commit(s):

• 0118d484509c06254bbc8f392ab2eb6ca06ea18a
• b8dd6b39775739bf732951723d580e8d50e3aef1
• 6c415782a27c9d70e8344efd235ffb142fc3736c
• 4860f31cd285f50cb06f3f5f9d03d3664cf9b6e6
• a103b640a91c8c232d0950ae7486908f13ecd361

The fix will be available with the upcoming 2.4.2 release.