Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] [Admin][improvement] Do not allow HTML tags for product attribute options when type is dropdown or multiple select #29602

Closed
4 tasks
m2-assistant bot opened this issue Aug 17, 2020 · 7 comments
Closed
4 tasks

[Issue] [Admin][improvement] Do not allow HTML tags for product attribute options when type is dropdown or multiple select #29602

m2-assistant bot opened this issue Aug 17, 2020 · 7 comments
Labels
Area: Catalog Component: Catalog Component: Eav Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2020

This issue is automatically created based on existing pull request: #27417: [Admin][improvement] Do not allow HTML tags for product attribute options when type is dropdown or multiple select

Description (*)

This PR aims to add a new validation for the options of the product attribute type "Dropdown", "Multiple Select" that checks whenever the option value contains HTML tags.

HTML tags are not useful nor displayed on the storefront for the product attribute options, those the store manager should be aware of it.

Related Pull Requests

#27371

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Go to the Admin area
  2. Go to Stores -> Attributes -> Product
  3. Press the button "Add New Attribute"
  4. Fill in the attribute default label
  5. Select the "Catalog Input Type for Store Owner" to "Dropdown" or "Multiple Select"
  6. In the section "Manage Options (Values of Your Attribute)" below add new options that contain HTML tags like <span>, </strong>, etc.
  7. Press the "Save and Continue Edit" or "Save Attribute" button
  8. See the error message
    Error message that says the option contains HTML tags

Questions or comments

Are the provided Unit and MFTF tests enough or there should be done more?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Catalog Component: Eav Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020
@vasilii-b vasilii-b mentioned this issue Aug 17, 2020
Closed
5 tasks
@ghost ghost assigned vasilii-b Aug 17, 2020
@ghost ghost added this to Ready for QA in Community Backlog Aug 17, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 17, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Aug 17, 2020
engcom-Foxtrot added a commit to vasilii-b/magento2 that referenced this issue Sep 18, 2020
@engcom-Foxtrot
magento#29602: [Admin][improvement] Do not allow HTML tags for produc…
5270844 
…t attribute options when type is dropdown or multiple select - installation fix.
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR in progress labels Sep 24, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 24, 2020
@sidolov sidolov added this to Pull Request In Progress in High Priority Backlog Oct 20, 2020
@ghost ghost removed this from PR In Progress in Community Backlog Oct 20, 2020
@ghost ghost removed this from Pull Request In Progress in Low Priority Backlog Oct 20, 2020
@ghost ghost added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 20, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Nov 16, 2020
@engcom-November engcom-November added Area: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Aug 25, 2021
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-1007 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Aug 25, 2021

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-1007

ngantrant pushed a commit to ngantrant/magento-2-open-source that referenced this issue May 18, 2024
@engcom-Foxtrot
magento/magento2#29602: [Admin][improvement] Do not allow HTML tags f…
52b3d38 
…or product attribute options when type is dropdown or multiple select.
@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service Magento Deployment Service
Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service Magento Deployment Service
Copy link

Hi @engcom-Bravo, here is your Magento Instance: https://f4b6a7bc8e6def04ce9746018c7326f5.instances-prod.magento-community.engineering
Admin access: https://f4b6a7bc8e6def04ce9746018c7326f5.instances-prod.magento-community.engineering/admin_fb83
Login: 06dffd73
Password: e07af4712a87

@engcom-Bravo
Copy link
Contributor

Hi @vasilii-b,

The Related PR has been closed.Hence We are Closing this issue.

Please feel free to open the issue.

Thanks.

@m2-community-project m2-community-project bot moved this from Ready for Development to Done in High Priority Backlog May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Catalog Component: Catalog Component: Eav Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
  
Done
Milestone
No milestone
5 participants
@vasilii-b @magento-engcom-team @engcom-Bravo @engcom-November @github-jira-sync-bot