Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Making message lock release possible #29616

Open
4 tasks
m2-assistant bot opened this issue Aug 17, 2020 · 0 comments · May be fixed by #26968
Open
4 tasks

[Issue] Making message lock release possible #29616

m2-assistant bot opened this issue Aug 17, 2020 · 0 comments · May be fixed by #26968
Assignees
Labels
Component: MessageQueue Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.3.x Indicates original Magento version for the Issue report. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2020

This issue is automatically created based on existing pull request: #26968: Making message lock release possible


Description (*)

Message can't be processed by the same consumer if it was rejected previuosly, beacause message lock is not released.
Example:
If we create dead-letter exchange (so far not possible using xml-s - see related PRs) we want our consumer to process the same message again later. It is not possible, because message is locked in db and we get exception here. It should be released here when message was rejected but it's not, because saving lock process create separate lock object, and one we pass as argument doesn't get populated with id.

I will fix test, as soon as solution will be accepted.

If PR will be accepted, please port to 2.3 as well.

Related Pull Requests

#26966
#26967

Manual testing scenarios (*)

  1. Publish message on queue
  2. Make consumer reject it
  3. Make consumer somehow consume it again (for example dead letter exchange)
  4. Message should be consumer and acked or rejected again, but not because of lock.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: MessageQueue Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020
@bartoszkubicki bartoszkubicki linked a pull request Aug 17, 2020 that will close this issue
5 tasks
@ghost ghost added this to Ready for QA in Community Backlog Aug 17, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 17, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for QA labels Sep 24, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.x Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Ready for QA in Community Backlog Nov 13, 2020
@m2-community-project m2-community-project bot added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Nov 13, 2020
@engcom-Dash engcom-Dash added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: MessageQueue Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.3.x Indicates original Magento version for the Issue report. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Low Priority Backlog
  
Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

3 participants