Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Use Object Cache for Category Links to avoid redundant calls #29654

Open
4 tasks
m2-assistant bot opened this issue Aug 18, 2020 · 2 comments
Open
4 tasks

[Issue] Use Object Cache for Category Links to avoid redundant calls #29654

m2-assistant bot opened this issue Aug 18, 2020 · 2 comments
Labels
Area: Catalog Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 18, 2020

This issue is automatically created based on existing pull request: #29565: Use Object Cache for Category Links to avoid redundant calls

Description (*)

Having 52 products in cart, I get 156 requests to the database:
image
This PR goal is to reduce this to 52.

After change, for 26 products:
image

This is a part of #29376 process.

Related Pull Requests

Fixed Issues (if relevant)

  1. Continuation of Checkout / Sales Rules / Get rid of redundant DB query #29376

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Catalog Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 18, 2020
@lbajsarowicz lbajsarowicz mentioned this issue Aug 18, 2020
Closed
5 tasks
@ghost ghost assigned lbajsarowicz Aug 18, 2020
@ghost ghost added this to Ready for QA in Community Backlog Aug 18, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Aug 18, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 18, 2020
@ghost ghost unassigned lbajsarowicz Sep 16, 2020
@ghost ghost moved this from PR In Progress to Ready for QA in Community Backlog Sep 16, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@sidolov sidolov added this to Ready for Development in High Priority Backlog Oct 20, 2020
@ghost ghost removed this from Ready for QA in Community Backlog Oct 20, 2020
@ghost ghost removed this from Ready for Grooming in Low Priority Backlog Oct 20, 2020
@engcom-Bravo engcom-Bravo added Area: Catalog Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 25, 2021
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-999 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Aug 25, 2021

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Catalog Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
  
Ready for Development
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Object Cache for Category Links to avoid redundant calls lbajsarowicz/magento2
4 participants
@lbajsarowicz @magento-engcom-team @engcom-Bravo @github-jira-sync-bot