Checkout / Sales Rules / Get rid of redundant DB query

[lbajsarowicz]

Description (*)

• Loading data in the loop?
• No, thank you!

By replacing direct SQL query with Data Provider that was already used in this Validator class allowed me to drastically reduce the cost of checkout placing process.

Local environment

20 products in cart

Custom project

22 products in cart

Related Pull Requests

Fixed Issues (if relevant)

Performance of Checkout

Manual testing scenarios (*)

1. Install sample data
2. Create Catalog rule based on category
3. Add plenty of products (15 - inf.)
4. Place an order.

Enjoy the pleasure of the checkout faster by 20 - 30% (and/or) send me a good whiskey

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Checkout / Sales Rules / Get rid of redundant DB query #29453: Checkout / Sales Rules / Get rid of redundant DB query

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[lbajsarowicz]

@magento run all tests

[ihor-sviziev]

@slavvka @lenaorobei is there an ability to run performance against 2.4-develop and for this PR? Would be good to check the diff. I think this is the only one way to measure this improvement with automated tests

[IvanChepurnyi]

Nice performance optimization @lbajsarowicz, would be great also to remove the singular query with preloaded category ids into this service by using afterload even on product collection in the shopping cart.

[lbajsarowicz]

@magento run Static Tests, Unit Tests

These failed due to implementation testing. SVC has to be approved by Magento crew.

[ihor-sviziev]

Hi @lbajsarowicz,
Could you implement following suggestion? #29376 (comment)

[lbajsarowicz]

@ihor-sviziev That is the subject for another PR.
With the delays caused by Product Owners from Adobe, I'd prefer to do it separately.

(This will require a set of additional Integration tests)

[ihor-sviziev]

@lbajsarowicz I don't mind to improve solution with small steps.
@magento run all tests

[ihor-sviziev]

✔ Approved.

Failing SVC test looks false positive

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7950 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Install Magento with sample data
2. Create Catalog rule based on category
3. Add plenty of products (50 in my case)
4. Place an order.

Local environment

Before: ✖️

After: ✔️
50 products in cart

[engcom-Alfa]

@magento create issue

[m2-assistant]

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.