Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit search button in form-mini should be disabled until minimum search length is reached #29704

Closed
4 tasks
markshust opened this issue Aug 20, 2020 · 7 comments · Fixed by #29724
Closed
4 tasks

Submit search button in form-mini should be disabled until minimum search length is reached #29704

markshust opened this issue Aug 20, 2020 · 7 comments · Fixed by #29724
Assignees
@konarshankar07
Labels
Area: Frontend Component: Search Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog

Comments

@markshust
Copy link
Contributor

markshust commented Aug 20, 2020 •
edited
Loading

Preconditions (*)

  1. Base install of Magento 2.4.0 with sample data installed.
  2. The issue is prevalent on every operating system and browser.

Steps to reproduce (*)

  1. Focus on form-mini search box.
  2. Type one or two alphanumeric characters in search box.

Expected result (*)

  • Submit button (magnifying glass) remains disabled until minimum search length is reached:
    Screen Shot 2020-08-20 at 2 34 09 PM-disabled

Actual result (*)

  • Submit button (magnifying glass) becomes enabled even if minimum search length is not reached:
    Screen Shot 2020-08-20 at 2 34 09 PM

Additional Info

Minimum search length is defined in the related component at https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Search/view/frontend/web/js/form-mini.js#L33

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ X ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@ghost ghost added this to Ready for QA in Community Backlog Aug 20, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 20, 2020
@krishprakash krishprakash self-assigned this Aug 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 21, 2020 •
edited by krishprakash
Loading

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your Magento instance.
Admin access: https://i-29704-2-4-develop.instances.magento-community.engineering/admin_d0b2
Login: 8cc91991 Password: 5246ac252660
Instance will be terminated in up to 3 hours.

@krishprakash krishprakash added Area: Frontend Component: Search Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 21, 2020
@ghost ghost unassigned krishprakash Aug 21, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog Aug 21, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 21, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-36904 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@konarshankar07
Copy link
Contributor

@magento I'm working on this

@konarshankar07 konarshankar07 mentioned this issue Aug 24, 2020
Merged
4 tasks
@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog Aug 24, 2020
@ghost ghost added Progress: PR in progress Priority: P3 May be fixed according to the position in the backlog. and removed Progress: ready for dev labels Aug 24, 2020
@m2-community-project m2-community-project bot added this to Ready for Development in Low Priority Backlog Sep 4, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in Low Priority Backlog Sep 4, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for dev labels Sep 4, 2020
@magento-engcom-team magento-engcom-team added Progress: ready for dev and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 4, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Sep 4, 2020
@sivaschenko
Copy link
Member

Hi @markshust. Thank you for your report.
The issue has been fixed in #29724 by @konarshankar07 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@sivaschenko sivaschenko added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 7, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Sep 7, 2020
magento-engcom-team added a commit that referenced this issue Sep 7, 2020
@magento-engcom-team
ENGCOM-8067: #29704 :- Submit search button in form-mini should be di…
7b68af8 
…sabled until minimum search length is reached #29724

 - Merge Pull Request #29724 from konarshankar07/magento2:fixed-search-button-disabled-issue--task-29704
 - Merged commits:
   1. f230257
   2. 1973efb
   3. 50b83be
   4. 268277e
magento-engcom-team pushed a commit that referenced this issue Sep 7, 2020
@gabrieldagama
ENGCOM-8067: #29704 :- Submit search button in form-mini should be di…
46b6ed5 
…sabled until minimum search length is reached #29724
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Done (last 30 days) in Community Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konarshankar07 konarshankar07

Labels
Area: Frontend Component: Search Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog
  
Done
Milestone
No milestone
5 participants
@markshust @sivaschenko @magento-engcom-team @konarshankar07 @krishprakash