Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Fixed the wrong code style in return type declaration #29712

Closed
4 tasks
m2-assistant bot opened this issue Aug 21, 2020 · 1 comment · Fixed by #29703
Closed
4 tasks

[Issue] Fixed the wrong code style in return type declaration #29712

m2-assistant bot opened this issue Aug 21, 2020 · 1 comment · Fixed by #29703
Assignees
@andrewbess
Labels
Component: Captcha Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Community Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 21, 2020

This issue is automatically created based on existing pull request: #29703: Fixed the wrong code style in return type declaration

Description (*)

This pull request (PR) fixes the wrong code style of the return type declaration

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Captcha Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Aug 21, 2020
@andrewbess andrewbess mentioned this issue Aug 21, 2020
Merged
5 tasks
@ghost ghost assigned andrewbess Aug 21, 2020
@ghost ghost added this to Ready for QA in Community Backlog Aug 21, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 21, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Aug 21, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #29703 by @andrewbess in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Aug 24, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Aug 24, 2020
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewbess andrewbess

Labels
Component: Captcha Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed the wrong code style in return type declaration andrewbess/magento2ce
2 participants
@andrewbess @magento-engcom-team