Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Fix code breaking comma in array_merge_recursive #29756

Closed
m2-assistant bot opened this issue Aug 26, 2020 · 3 comments
Closed

[Issue] Fix code breaking comma in array_merge_recursive #29756

m2-assistant bot opened this issue Aug 26, 2020 · 3 comments
Labels
Component: Setup Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2020

This issue is automatically created based on existing pull request: #29755: Fix code breaking comma in array_merge_recursive


The unnecessary comma caused an error message when the cache status was read (php ./bin/magento cache:status).

The error message: "Parse error: syntax error, unexpected ')' in ./setup/src/Magento/Setup/Module.php on line 82"

After removal of the comma, all code relating to this class kept working as intended.

@m2-assistant m2-assistant bot added Component: Setup Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Aug 26, 2020
@ghost ghost added this to Ready for QA in Community Backlog Aug 26, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Aug 26, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 26, 2020
@ghost ghost moved this from PR In Progress to Ready for QA in Community Backlog Aug 27, 2020
@shikhamis11
Copy link
Member

closing since replated PR #29755 is already closed

@ghost ghost moved this from Ready for QA to Done (last 30 days) in Community Backlog Aug 29, 2020
This was referenced Sep 21, 2020
@ihor-sviziev ihor-sviziev added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Sep 21, 2020
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Sep 21, 2020

This is not an issue. Magento 2.4 is supporting only php 7.3 and php 7.4, and trailing comma is allowed in those versions.

Trailing coma in function calls was implemented in php 7.3 that minumum supported version in magento 2.4.x, so probably you're trying to run Magento on some not compatible php version.

@nicholasscottfish
Copy link

This is common on environments running multiple php versions. Running 'which php' on the server will confirm which version of php the command line is using; in our case we had to specify php 7.4 when running commands manually:

/usr/bin/php74 bin/magento admin:user:create

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Setup Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
No open projects
Community Backlog
  
Done (last 30 days)
4 participants