Update Module.php

[tejasklevu]

A comma in the array when it is ending

Description (*)

I tried to run normal Upgrade command on CLI and got the error as below:
PHP Parse error: syntax error, unexpected ')' in setup\src\Magento\Setup\Module.php on line 82
After seeing the code, there was unnecessary comma present in the code that I removed in my pull request. This fixed my issue as well.

Manual testing scenarios (*)

1. Install magento 2.4 and perform the below command on CLI:
2. php -d memory_limit=-1 bin/magento setup:upgrade

Contribution checklist (*)

• [*] Pull request has a meaningful description of its purpose
• [*] All commits are accompanied by meaningful commit messages
• [*] All new or changed code is covered with unit/integration tests (if applicable)
• [*] All automated tests passed successfully (all builds are green)

Fixes #29756

[m2-assistant]

Hi @tejasklevu. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@tejasklevu
From first look - looks good.

1. Could you add your used php version?
2. Could you sign Adobe CLA?

@magento run all tests

[ihor-sviziev]

@tejasklevu
From first look - looks good, but actually trailing coma in function calls was implemented in php 7.3 that minumum supported version in magento 2.4.x, so not sure why are you getting this issue.

Could you add your used php version?
Could you sign Adobe CLA?

[tejasklevu]

Hi @ihor-sviziev i checked again found my PHP CLI version was PHP 7.2.X and that created this issue.
But also, I found in the PHP docs as below lines:

"The comma after the last array element is optional and can be omitted. This is usually done for single-line arrays, i.e. array(1, 2) is preferred over array(1, 2, ). For multi-line arrays on the other hand the trailing comma is commonly used, as it allows easier addition of new elements at the end."

So as a code improvement, this pull request can be accepted?

[ihor-sviziev]

Hi @tejasklevu,

For multi-line arrays on the other hand the trailing comma is commonly used, as it allows easier addition of new elements at the end.

I prefer to reject this PR as issue isn't reproducing on the supported php versions and basically this change isn't doing any improvement.
Thank you so much for your contribution!

[m2-assistant]

Hi @tejasklevu, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.