Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"The coupon code has been accepted." message remains after a Coupon Code was removed #30255

Closed
magento-engcom-team opened this issue Sep 30, 2020 · 6 comments · Fixed by #30391
Closed

"The coupon code has been accepted." message remains after a Coupon Code was removed #30255

magento-engcom-team opened this issue Sep 30, 2020 · 6 comments · Fixed by #30391
Assignees
@shikhamis11
Labels
CD Issue recommended for the contribution day Component: Other Event: Distributed CD India 2020 Event: dmcdindia2020 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog

Comments

@magento-engcom-team
Copy link
Contributor

Preconditions

  1. Create simple product

  2. Create Customer with address

  • First Name: John
  • Last Name: Doe
  • Email Address: john.doe@example.com(use real mail)
  • Company: Magento
  • Address: 6161 West Centinela Avenue
  • City: Culver City
  • State/Province: California (CA)
  • Zip/Postal Code: 90230
  • Country: United States
  • Telephone: 555-55-555-55
  1. Go to Admin -> Marketing -> Cart Price Rules: click "Add New Rule"
  • Fill all required fields
    • "Coupon" select Specific Coupon
    • "Coupon Code" = 1111
  • In "Action" section
    • "Apply" select "Percent of product price discount"
    • "Discount Amount" = 50
  • click "Save" button

Steps:

  1. Go to admin -> sales -order -> create new order -> select customer
  2. Add Products => simple product
  3. Apply Coupon Code => 1111
  4. remove Coupon Code

(/) Expected result
"The coupon code has been accepted." message should disappear

(x) Actual result
"The coupon code has been accepted." message is still present
@magento-engcom-team
Copy link
Contributor Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-37386

@magento-engcom-team magento-engcom-team added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 30, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 30, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Grooming in Low Priority Backlog Sep 30, 2020
@magento-engcom-team magento-engcom-team added Component: Other Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Sep 30, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Ready for Development in Low Priority Backlog Sep 30, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 30, 2020
@magento-engcom-team
Copy link
Contributor Author

✅ Confirmed by @magento-engcom-team
Thank you for verifying the issue. Based on the provided information internal tickets MC-37386 were created

Issue Available: @magento-engcom-team, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sivaschenko sivaschenko added the CD Issue recommended for the contribution day label Oct 7, 2020
@shikhamis11
Copy link
Member

@magento I am working on this

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in Low Priority Backlog Oct 9, 2020
@shikhamis11
Copy link
Member

#dmcdindia2020

shikhamis11 pushed a commit to cedcommerce/magento2 that referenced this issue Oct 10, 2020
magento#30255: Fixed "The coupon code has been accepted." message rem…
f54561e 
…ains after a Coupon Code was removed

Fixed "The coupon code has been accepted." message remains after a Coupon Code was removed
@shikhamis11 shikhamis11 mentioned this issue Oct 10, 2020
Merged
4 tasks
shikhamis11 added a commit to cedcommerce/magento2 that referenced this issue Oct 10, 2020
@shikhamis11
magento#30255: Fixed The coupon code has been accepted. message remai…
16e962d 
…ns after a Coupon Code was removed

reverted previous changes and updated requested changes
shikhamis11 added a commit to cedcommerce/magento2 that referenced this issue Oct 13, 2020
@shikhamis11
magento#30255:magento#30255: Fixed The coupon code has been accepted …
9c09485 
…message

Fixed Static test
Added MFTF Test to Verify Remove coupon code
shikhamis11 added a commit to cedcommerce/magento2 that referenced this issue Oct 19, 2020
@shikhamis11
magento#30255: Fixed The coupon code has been accepted message
15fdf8d 
Added after action for disable Flatrate in MFTF test
Added Verification for previous message removed
@sidolov sidolov added this to Dev In Progress in High Priority Backlog Oct 20, 2020
@ghost ghost moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Oct 20, 2020
@ghost ghost moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Oct 22, 2020
@ghost ghost moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Oct 22, 2020
@ghost ghost moved this from Ready for Development to Dev In Progress in High Priority Backlog Oct 22, 2020
shikhamis11 added a commit to cedcommerce/magento2 that referenced this issue Nov 4, 2020
@shikhamis11
magento#30255: Fixed The coupon code has been accepted message
2362ad9 
Removed comments
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog Nov 5, 2020
shikhamis11 pushed a commit to cedcommerce/magento2 that referenced this issue Nov 5, 2020
magento#30255: Fixed The coupon code has been accepted message
28376be 
updated `severity` and `testCaseId` for added MFTF test
shikhamis11 pushed a commit to cedcommerce/magento2 that referenced this issue Nov 5, 2020
magento#30255: Fixed The coupon code has been accepted message
d011456 
removed disable flat rate step from after action
@gabrieldagama gabrieldagama added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Nov 13, 2020
@gabrieldagama
Copy link
Contributor

Hi @magento-engcom-team. Thank you for your report.
The issue has been fixed in #30391 by @shikhamis11 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@m2-community-project m2-community-project bot moved this from Ready for Development to Done in High Priority Backlog Nov 13, 2020
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in High Priority Backlog Nov 13, 2020
magento-engcom-team added a commit that referenced this issue Nov 13, 2020
@magento-engcom-team
ENGCOM-8426: #30255: Fixed 'The coupon code has been accepted.' messa…
2ccc605 
…ge remains after a Coupon Code was removed #30391

 - Merge Pull Request #30391 from cedcommerce/magento2:2.4-dev_30255
 - Merged commits:
   1. f54561e
   2. 16e962d
   3. 9c09485
   4. 1ee91ca
   5. 15fdf8d
   6. 2362ad9
   7. 28376be
   8. d011456
magento-engcom-team pushed a commit that referenced this issue Nov 13, 2020
@gabrieldagama
ENGCOM-8426: #30255: Fixed "The coupon code has been accepted." messa…
32c4c3e 
…ge remains after a Coupon Code was removed #30391
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Aug 25, 2021
@m2-community-project m2-community-project bot moved this from Ready for Development to Done in High Priority Backlog Aug 25, 2021
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shikhamis11 shikhamis11

Labels
CD Issue recommended for the contribution day Component: Other Event: Distributed CD India 2020 Event: dmcdindia2020 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
  
Done
Milestone
No milestone
5 participants
@sivaschenko @gabrieldagama @shikhamis11 @magento-engcom-team @github-jira-sync-bot