Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design issue in minicart item remove confirmation modal. #30452

Closed
5 tasks
saumya1998 opened this issue Oct 12, 2020 · 15 comments · Fixed by #30458
Closed
5 tasks

Design issue in minicart item remove confirmation modal. #30452

saumya1998 opened this issue Oct 12, 2020 · 15 comments · Fixed by #30458
Assignees
Labels
Area: Design/Frontend Component: Ui Event: dmcdindia2020 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.

Comments

@saumya1998
Copy link

Design issue in minicart item remove confirmation modal.

Preconditions (*)

1.magento version - magento2-2.4-develop
2.php version - PHP 7.4.11
3.view - mobile view

Steps to reproduce (*)

  1. open magento base url.
  2. open product and add to cart
  3. now open minicart in top right corner.
  4. click on delete button side to edit button
  5. check the modal content design in mobile view.

Expected result (*)

Screenshot_2020-10-12_15-29-53

Actual result (*)

Screenshot(16)


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Oct 12, 2020

Hi @saumya1998. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@saumya1998
Copy link
Author

#dmcdindia2020

@m2-assistant
Copy link

m2-assistant bot commented Oct 12, 2020

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@m2-community-project m2-community-project bot moved this from Ready for Grooming to Dev In Progress in Low Priority Backlog Oct 12, 2020
@ajijshekh123
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @ajijshekh123. Thank you for your request. I'm working on Magento instance for you.

@ajijshekh123
Copy link

ajijshekh123 commented Oct 12, 2020

Hi @saumya1998,
I have verified the issue in iPhone X (375 * 812) and iPhone 6/7/8 (414 * 736) size but not able to reproduce the issue.
PFA:
image

image

Can you please update me on which size you are facing the issue?

Thanks.

@saumya1998
Copy link
Author

saumya1998 commented Oct 12, 2020

@ajijshekh123
Screenshot_2020-10-12_16-32-33
i am checking on Galaxy s5 (360x640). And below screen size 360 ex. iphone 5/SE (320)

@ajijshekh123
Copy link

ajijshekh123 commented Oct 12, 2020

Hi @saumya1998,
I think this is not an issue. Popup UI content size depends on the device. Please update me on your concern.
PFA:
image

Thanks.

@saumya1998
Copy link
Author

saumya1998 commented Oct 12, 2020

@ajijshekh123 , if you will check form code there is issue, like both left and right padding should be same but now, the right padding is 7rem and left padding is 3 rem. this is why the content is align with left side in mobile view. if both side padding will be same then the content will show aligned equally from both sides.
Screenshot_2020-10-12_16-46-18

@ajijshekh123
Copy link

Okay @saumya1998, Thanks for the update. Let me verify the issue. You can proceed with your work after confirming the issue.

@ajijshekh123 ajijshekh123 added Area: Design/Frontend Component: Ui Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 12, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @ajijshekh123
Thank you for verifying the issue. Based on the provided information internal tickets MC-38347 were created

Issue Available: @ajijshekh123, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 12, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in Low Priority Backlog Oct 12, 2020
@saumya1998
Copy link
Author

I am working on this issue.

@niravkrish
Copy link
Contributor

@magento I am working on this

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in Low Priority Backlog Oct 12, 2020
@sidolov sidolov added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Oct 12, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in Low Priority Backlog Oct 12, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: dev in progress labels Oct 12, 2020
@magento-engcom-team magento-engcom-team added Progress: ready for dev and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 13, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Oct 13, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Oct 16, 2020
@magento-engcom-team
Copy link
Contributor

Hi @saumya1998. Thank you for your report.
The issue has been fixed in #30458 by @niravkrish in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@m2-community-project m2-community-project bot moved this from Ready for Development to Done in Low Priority Backlog Oct 16, 2020
@sdzhepa sdzhepa added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Nov 11, 2020
@magento-engcom-team magento-engcom-team added Reported on 2.4.0 Indicates original Magento version for the Issue report. and removed Reported on 2.4.x Indicates original Magento version for the Issue report. labels Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Component: Ui Event: dmcdindia2020 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Development

Successfully merging a pull request may close this issue.

6 participants