Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixed-30452] - Design issue in minicart item remove confirmation modal #30458

Merged
merged 1 commit into from
Oct 16, 2020
Merged

[Fixed-30452] - Design issue in minicart item remove confirmation modal #30458

merged 1 commit into from
Oct 16, 2020

Conversation

niravkrish
Copy link
Contributor

Description (*)

Design issue in minicart item removes confirmation modal.

Preconditions (*)

  1. magento version - magento2-2.4-develop
  2. php version - PHP 7.4.11
  3. view - mobile view

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Design issue in minicart item remove confirmation modal. #30452

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 12, 2020

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Oct 12, 2020
@niravkrish niravkrish changed the title removed unneccesary css to resolve the issue [Fixed-30452] - Design issue in minicart item remove confirmation modal Oct 12, 2020
@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 12, 2020
ptylek
ptylek suggested changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@ptylek ptylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This padding was added in order to fix #19263 Can you also check how to fix it for both cases?

@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Oct 12, 2020
@ghost ghost assigned ptylek Oct 12, 2020
@niravkrish
Copy link
Contributor Author

@magento give me test instance

@magento-deployment-service
Copy link

Hi @niravkrish. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @niravkrish, here is your Magento Instance: https://e4789e4d32ed4a73aa5c52c21c06a8bc.instances.magento-community.engineering
Admin access: https://e4789e4d32ed4a73aa5c52c21c06a8bc.instances.magento-community.engineering/admin_4721
Login: b1e41114
Password: 9e483887078d

@niravkrish
Copy link
Contributor Author

Hi @ptylek ,

Please check in the test instance now the older workaround not needed. Please check the attached screenshot.

screenshot-e4789e4d32ed4a73aa5c52c21c06a8bc instances magento-community engineering-2020 10 13-09_37_41

also, check the below PR.
https://github.com/magento/magento2/pull/19986/files

Thanks & Regards,
Nirav Patel

@niravkrish
Copy link
Contributor Author

@magento run all tests

ptylek
ptylek approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@ptylek ptylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking @niravkrish

Failed test is not related to this PR.

@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Oct 13, 2020
@ptylek ptylek added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 13, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-8336 has been created to process this Pull Request
✳️ @ptylek, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Oct 13, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Oct 13, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. open magento base url.
  2. open product and add to cart
  3. now open minicart in top right corner.
  4. click on delete button side to edit button
  5. check the modal content design in mobile view.

Before: ✖️

Screenshot from 2020-10-13 11-41-51

After: ✔️

Screenshot from 2020-10-13 11-42-07

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 13, 2020
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Oct 13, 2020
@engcom-Foxtrot engcom-Foxtrot self-assigned this Oct 13, 2020
@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Oct 13, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Oct 16, 2020
Closed
5 tasks
magento-engcom-team pushed a commit that referenced this pull request Oct 16, 2020
@sidolov
ENGCOM-8336: [Fixed-30452] - Design issue in minicart item remove con…
442caf2 
…firmation modal #30458
@magento-engcom-team magento-engcom-team merged commit 9e0170a into magento:2.4-develop Oct 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 16, 2020

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptylek ptylek ptylek approved these changes

Assignees

@ptylek ptylek

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design issue in minicart item remove confirmation modal.
6 participants
@niravkrish @magento-engcom-team @engcom-Alfa @ptylek @sidolov @engcom-Foxtrot