Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Fixed placeholder translation in Magento UI grid search component #30510

Closed
2 tasks done
m2-assistant bot opened this issue Oct 16, 2020 · 2 comments · Fixed by #30493
Closed
2 tasks done

[Issue] Fixed placeholder translation in Magento UI grid search component #30510

m2-assistant bot opened this issue Oct 16, 2020 · 2 comments · Fixed by #30493
Assignees
@vveb-developer
Labels
Component: Ui Event: MageCONF CD 2020 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Low Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 16, 2020 •
edited by engcom-Alfa
Loading

This issue is automatically created based on existing pull request: #30493: Fixed placeholder translation in Magento UI grid search component

Fixed translations in Magento UI grid search component

Precondition (*)

Magento 2.4-develop

Description (*)

Grid search input placeholder is not translated. Even if a phrase exists in translations csv file, translation will not be shown in UI since in js component function $t() are not used.

Manual testing scenarios (*)

  1. Install any language pack, which contains translation of phrase 'Search by keyword'.
  2. Turn on appropriate language
  3. Look at any grid in the backend.

Actual Result: ✖️ Phrase 'Search by keyword' is not translated.

2020-10-16_11-38

Expected Result: ✔️ Phrase 'Search by keyword' should be translated.

2020-10-16_11-34

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
@m2-assistant m2-assistant bot added Component: Ui Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 16, 2020
@m2-assistant m2-assistant bot mentioned this issue Oct 16, 2020
Merged
3 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Oct 16, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 16, 2020
@engcom-Alfa engcom-Alfa added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Oct 16, 2020
@m2-community-project m2-community-project bot added Progress: ready for dev and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 16, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Oct 16, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 16, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-38490 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #30493 by @vveb-developer in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Oct 24, 2020
@ghost ghost moved this from Ready for Development to Done in Low Priority Backlog Oct 24, 2020
@ghost ghost moved this from Done to Pull Request In Progress in Low Priority Backlog Oct 24, 2020
@ghost ghost moved this from Pull Request In Progress to Done in Low Priority Backlog Oct 24, 2020
@sdzhepa sdzhepa added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Nov 11, 2020
@magento-engcom-team magento-engcom-team added Reported on 2.4.0 Indicates original Magento version for the Issue report. and removed Reported on 2.4.x Indicates original Magento version for the Issue report. labels Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vveb-developer vveb-developer

Labels
Component: Ui Event: MageCONF CD 2020 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Low Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed placeholder translation in Magento UI grid search component vveb-developer/magento2
4 participants
@sdzhepa @vveb-developer @magento-engcom-team @engcom-Alfa