-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed placeholder translation in Magento UI grid search component #30493
Fixed placeholder translation in Magento UI grid search component #30493
Conversation
Hi @vveb-developer. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE |
@magento run Functional Tests B2B |
Hi @ihor-sviziev, thank you for the review. |
@vveb-developer thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Hi @ptylek, thank you for the review. |
@magento create issue |
Hi @vveb-developer, thank you for your contribution! |
Fixed translations in Magento UI grid search component
Description (*)
Grid search input placeholder is not translated. Even if a phrase exists in translations csv file, translation will not be shown in UI since in js component function
$t()
are not used.Manual testing scenarios (*)
Contribution checklist (*)
Resolved issues: