Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed placeholder translation in Magento UI grid search component #30493

Conversation

vveb-developer
Copy link
Contributor

@vveb-developer vveb-developer commented Oct 14, 2020

Fixed translations in Magento UI grid search component

Description (*)

Grid search input placeholder is not translated. Even if a phrase exists in translations csv file, translation will not be shown in UI since in js component function $t() are not used.

Manual testing scenarios (*)

  1. Install any language pack, which contains translation of phrase 'Search by keyword'.
  2. Turn on appropriate language
  3. Look at any grid in backend. Phrase 'Search by keyword' is not translated.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

Resolved issues:

  1. resolves [Issue] Fixed placeholder translation in Magento UI grid search component #30510: Fixed placeholder translation in Magento UI grid search component

@m2-assistant
Copy link

m2-assistant bot commented Oct 14, 2020

Hi @vveb-developer. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Oct 14, 2020
@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 14, 2020
@ihor-sviziev ihor-sviziev self-assigned this Oct 15, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ghost ghost moved this from Pending Review to Review in Progress in Pull Requests Dashboard Oct 15, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: pending review Award: bug fix labels Oct 15, 2020
@ghost ghost moved this from Review in Progress to Pending Review in Pull Requests Dashboard Oct 15, 2020
@ghost ghost removed the Progress: review label Oct 15, 2020
@ghost ghost moved this from Pending Review to Review in Progress in Pull Requests Dashboard Oct 15, 2020
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B

@ghost ghost moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Oct 15, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8344 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@vveb-developer thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ghost ghost assigned ptylek Oct 15, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-8344 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Oct 16, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Oct 16, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

  1. Install any language pack, which contains translation of phrase 'Search by keyword'.
  2. Turn on appropriate language
  3. Look at any grid in the backend.

Before: ✖️ Phrase 'Search by keyword' is not translated.

2020-10-16_11-38

After: ✔️ Phrase 'Search by keyword' is translated.

2020-10-16_11-34

@engcom-Alfa
Copy link
Contributor

@magento create issue

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 16, 2020
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Oct 16, 2020
@engcom-Foxtrot engcom-Foxtrot self-assigned this Oct 16, 2020
@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Oct 16, 2020
@magento-engcom-team magento-engcom-team merged commit 02aca81 into magento:2.4-develop Oct 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2020

Hi @vveb-developer, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Ui Event: MageCONF CD 2020 Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

[Issue] Fixed placeholder translation in Magento UI grid search component
7 participants