Skip to content

[Issue] Initialize authentication popup modal only when needed #30672

@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #30647: Initialize authentication popup modal only when needed


Description (*)

This PR is somehow an evolution of the #27686 in which I have found that it is not possible to completely skip initialization of authentication popup. That said, by adding this additional check, we are able to save a lot of CPU time for all of the shops that have guest checkout enabled.

Here are the profiles of before:
auth-popup-before
and after:
auth-popup-after

Manual testing scenarios (*)

  1. setModalElement function is no longer called when guest checkout is enabled.
  2. Authentication popup still shows properly when guest user tries to go to the checkout but guest checkout is disabled.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Component: CustomerIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.0Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions