[Issue] Initialize authentication popup modal only when needed #30672
Labels
Component: Customer
Issue: Confirmed
Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed
Priority: P2
A defect with this priority could have functionality issues which are not to expectations.
Progress: done
Reported on 2.4.0
Indicates original Magento version for the Issue report.
Reproduced on 2.4.x
The issue has been reproduced on latest 2.4-develop branch
Severity: S3
Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
This issue is automatically created based on existing pull request: #30647: Initialize authentication popup modal only when needed
Description (*)
This PR is somehow an evolution of the #27686 in which I have found that it is not possible to completely skip initialization of authentication popup. That said, by adding this additional check, we are able to save a lot of CPU time for all of the shops that have guest checkout enabled.
Here are the profiles of before:
![auth-popup-before](https://user-images.githubusercontent.com/829189/97103431-c29a2500-16ac-11eb-8b4a-2508b5eef31d.png)
![auth-popup-after](https://user-images.githubusercontent.com/829189/97103435-c8900600-16ac-11eb-8a75-bb105d228b85.png)
and after:
Manual testing scenarios (*)
setModalElement
function is no longer called when guest checkout is enabled.Contribution checklist (*)
The text was updated successfully, but these errors were encountered: