Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Developer Experience: Make getAdditionalConfig extensible #30787

Open
4 tasks
m2-assistant bot opened this issue Nov 4, 2020 · 0 comments · May be fixed by #30718
Open
4 tasks

[Issue] Developer Experience: Make getAdditionalConfig extensible #30787

m2-assistant bot opened this issue Nov 4, 2020 · 0 comments · May be fixed by #30718
Assignees
Labels
Component: ConfigurableProduct Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Milestone

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 4, 2020

This issue is automatically created based on existing pull request: #30718: Developer Experience: Make getAdditionalConfig extensible


Description (*)

For 2.5 branch

Currently when you need to add some extra data to Configurable Swatches, you need either:

  • Inherit class and add your custom elements
  • Plugin end decode the data before adding your

Example from Extension Vendor code:
image

To avoid such situations, I introduced the change that enables us to put our own data in Swatch config without unnecessary hassle.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: ConfigurableProduct Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 4, 2020
@m2-assistant m2-assistant bot linked a pull request Nov 4, 2020 that will close this issue
5 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Nov 4, 2020
@ghost ghost unassigned lbajsarowicz Nov 29, 2020
@gabrieldagama gabrieldagama added this to the 2.5 milestone Jan 25, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in 2.5 Milestone Backlog Jan 25, 2021
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in Low Priority Backlog Jan 25, 2021
@engcom-Dash engcom-Dash added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 7, 2024
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Mar 7, 2024
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in 2.5 Milestone Backlog Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ConfigurableProduct Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Low Priority Backlog
  
Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

3 participants