Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Experience: Make getAdditionalConfig extensible #30718

Open
wants to merge 2 commits into
base: 2.5-develop
Choose a base branch
from

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Oct 30, 2020

Description (*)

For 2.5 branch

Currently when you need to add some extra data to Configurable Swatches, you need either:

  • Inherit class and add your custom elements
  • Plugin end decode the data before adding your

Example from Extension Vendor code:
image

To avoid such situations, I introduced the change that enables us to put our own data in Swatch config without unnecessary hassle.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Developer Experience: Make getAdditionalConfig extensible #30787: Developer Experience: Make getAdditionalConfig extensible

@m2-assistant
Copy link

m2-assistant bot commented Oct 30, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

I don't remember if I can add a new public method to this specific class.

@ihor-sviziev ihor-sviziev self-assigned this Oct 30, 2020
@ghost ghost moved this from Pending Review to Review in Progress in Pull Requests Dashboard Oct 30, 2020
@ihor-sviziev ihor-sviziev added this to the 2.5 milestone Oct 30, 2020
@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev
Copy link
Contributor

Looks good. Moving to "on hold" as it will wait for 2.5

@ihor-sviziev ihor-sviziev added Issue: On Hold Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Progress: review labels Oct 30, 2020
@ghost ghost moved this from Review in Progress to On Hold in Pull Requests Dashboard Oct 30, 2020
@ghost ghost added the Progress: on hold label Oct 30, 2020
@ghost ghost moved this from On Hold to Review in Progress in Pull Requests Dashboard Oct 30, 2020
@ghost ghost moved this from Review in Progress to On Hold in Pull Requests Dashboard Oct 30, 2020
@ghost ghost removed the Progress: review label Oct 30, 2020
@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lbajsarowicz,
Could you re-target your PR to 2.5-develop branch?

@m2-community-project m2-community-project bot moved this from On Hold to Changes Requested in Pull Requests Dashboard Jan 8, 2021
@lbajsarowicz lbajsarowicz changed the base branch from 2.4-develop to 2.5-develop January 8, 2021 17:14
@m2-community-project m2-community-project bot added this to Changes Requested in 2.5 Milestone PRs Dashboard Jan 22, 2021
@m2-community-project m2-community-project bot removed this from Changes Requested in Pull Requests Dashboard Jan 22, 2021
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests CE

@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in 2.5 Milestone PRs Dashboard Jan 29, 2021
@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in 2.5 Milestone PRs Dashboard Jan 29, 2021
@m2-community-project m2-community-project bot added this to Ready for Testing in Pull Requests Dashboard Mar 7, 2024
@m2-community-project m2-community-project bot removed this from Ready for Testing in 2.5 Milestone PRs Dashboard Mar 7, 2024
@engcom-Delta engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: ConfigurableProduct Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Release Line: 2.5 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Pull Requests Dashboard
  
Ready for Testing
Development

Successfully merging this pull request may close these issues.

[Issue] Developer Experience: Make getAdditionalConfig extensible
6 participants