Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Fix PHPdoc comment to be accurate #30833

Closed
3 of 4 tasks
m2-assistant bot opened this issue Nov 6, 2020 · 1 comment · Fixed by #30793
Closed
3 of 4 tasks

[Issue] Fix PHPdoc comment to be accurate #30833

m2-assistant bot opened this issue Nov 6, 2020 · 1 comment · Fixed by #30793
Assignees
@samuel27m
Labels
Component: CatalogImportExport Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Progress: PR in progress Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 6, 2020

This issue is automatically created based on existing pull request: #30793: Fix PHPdoc comment to be accurate

Fix PHPdoc comment to be accurate

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: CatalogImportExport Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Nov 6, 2020
@m2-assistant m2-assistant bot mentioned this issue Nov 6, 2020
Merged
5 tasks
@okorshenko okorshenko pinned this issue Nov 6, 2020
@okorshenko okorshenko unpinned this issue Nov 6, 2020
@gabrieldagama gabrieldagama added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Nov 13, 2020
@gabrieldagama
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #30793 by @samuel27m in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuel27m samuel27m

Labels
Component: CatalogImportExport Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Progress: PR in progress Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Low Priority Backlog
Status: Pull Request In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PHPdoc comment to be accurate
2 participants
@gabrieldagama @samuel27m