Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Item resolvers should be optional #30860

Closed
m2-assistant bot opened this issue Nov 9, 2020 · 2 comments · Fixed by #30823
Closed

[Issue] Item resolvers should be optional #30860

m2-assistant bot opened this issue Nov 9, 2020 · 2 comments · Fixed by #30823
Assignees
@thomas-kl1
Labels
Area: Catalog Component: Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 9, 2020 •
edited by engcom-Foxtrot
Loading

This issue is automatically created based on existing pull request: #30823: Item resolvers should be optional

Item resolvers should be optional. If we remove configurable and grouped product, checkout is broken because this argument is mandatory. Only the grouper and configurable product add item resolver.

Preconditions (*)

  1. Customer created
  2. Simple Product created

Steps to reproduce (*)

  1. Execute:
bin/magento module:disable Magento_GroupedImportExport
bin/magento module:disable Magento_GroupedCatalogInventory
bin/magento module:disable Magento_GroupedProductGraphQl
bin/magento module:disable Magento_MsrpGroupedProduct
bin/magento module:disable Magento_GroupedProduct
bin/magento module:disable Magento_CatalogRuleConfigurable
bin/magento module:disable Magento_MsrpConfigurableProduct
bin/magento module:disable Magento_NewRelicReporting
bin/magento module:disable Magento_ConfigurableProductGraphQl
bin/magento module:disable Magento_ConfigurableProductSales
bin/magento module:disable Magento_ConfigurableImportExport
bin/magento module:disable Magento_SwatchesGraphQl
bin/magento module:disable Magento_Swatches
bin/magento module:disable Magento_ConfigurableProduct
bin/magento setup:upgrade
  1. Login on storefront.
  2. Add Simple Product to cart.
  3. Go to Checkout.
  4. Create an Order.

Expected result (*)

  1. Product added to Cart.
  2. Order Created.

Actual result (*)

  1. Error on adding Product.
  2. Error on Checkout page.
@m2-assistant m2-assistant bot added Component: Catalog Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 9, 2020
@m2-assistant m2-assistant bot mentioned this issue Nov 9, 2020
Merged
1 task
@ghost ghost unassigned thomas-kl1 Dec 4, 2020
@ihor-sviziev ihor-sviziev added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 30, 2021
@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 6, 2021
@engcom-Oscar engcom-Oscar added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 8, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-41818 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ihor-sviziev ihor-sviziev removed the Priority: P3 May be fixed according to the position in the backlog. label Apr 8, 2021
@gabrieldagama
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #30823 by @thomas-kl1 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

@gabrieldagama gabrieldagama added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Apr 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomas-kl1 thomas-kl1

Labels
Area: Catalog Component: Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
High Priority Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Item resolvers should be optional thomas-kl1/magento2
7 participants
@ihor-sviziev @gabrieldagama @thomas-kl1 @magento-engcom-team @engcom-Bravo @engcom-Oscar @github-jira-sync-bot