Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Add event listeners passive for fotorama lib improves lighthouse metrics #31140

Closed
m2-assistant bot opened this issue Dec 2, 2020 · 5 comments · Fixed by #31080
Closed

[Issue] Add event listeners passive for fotorama lib improves lighthouse metrics #31140

m2-assistant bot opened this issue Dec 2, 2020 · 5 comments · Fixed by #31080
Assignees
@mrtuvn
Labels
Area: Perf/Frontend All tickets related with improving frontend performance. Component: Other Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 2, 2020 •
edited by engcom-Bravo
Loading

This issue is automatically created based on existing pull request: #31080: Add event listeners passive for fotorama lib improves lighthouse metrics

Description (*)

Improve lighthouse metrics score for fotorama js lib

Screenshot from 2020-11-27 22-30-28

Preconditions

2.4-develop

Steps to reproduce

  1. From Admin Panel, create a product
  2. From Storefront, open the previously created products page
  3. Right-click on the web page and select Inspect to open browsers dev console
  4. Switch to the Lighthouse tab
  5. Click Generate report
    gen_rep
  6. Observe the red scores under Diagnostics

Actual Result

The score for fotorama js lib was red
before2

Expected result

after

Manual testing scenario

  1. From Admin Panel, create a product
  2. From Storefront, open the previously created products page
  3. Right-click on the web page and select Inspect to open browsers dev console
  4. Switch to the Lighthouse tab
  5. Click Generate report
    gen_rep
  6. Observe the red scores under Diagnostics

BEFORE applying changes provided in the PR, the score for fotorama js lib was red
before2

AFTER switching to the PR
after
@m2-assistant m2-assistant bot added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 2, 2020
@m2-assistant m2-assistant bot mentioned this issue Dec 2, 2020
Merged
5 tasks
@engcom-Bravo engcom-Bravo added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Perf/Frontend All tickets related with improving frontend performance. Component: Other Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 4, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-39641 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@stale
Copy link

stale bot commented Feb 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Feb 18, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Feb 18, 2021

Still valid

@stale stale bot removed the stale issue label Feb 18, 2021
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 6, 2021
@gabrieldagama
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #31080 by @mrtuvn in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

@gabrieldagama gabrieldagama added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Apr 11, 2021
@IanFiretoys
Copy link

hi all, still seeing this on our live install of 2.4.3, is this potentially a theme issue, or is it not live in 2.4.3

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrtuvn mrtuvn

Labels
Area: Perf/Frontend All tickets related with improving frontend performance. Component: Other Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add event listeners passive for fotorama lib improves lighthouse metrics mrtuvn/magento2
6 participants
@mrtuvn @gabrieldagama @magento-engcom-team @IanFiretoys @engcom-Bravo @github-jira-sync-bot