Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Allow to load base64 encoded images and fonts #31170

Closed
2 of 4 tasks
m2-assistant bot opened this issue Dec 4, 2020 · 2 comments · Fixed by #31162
Closed
2 of 4 tasks

[Issue] Allow to load base64 encoded images and fonts #31170

m2-assistant bot opened this issue Dec 4, 2020 · 2 comments · Fixed by #31162
Assignees
Labels
Component: Csp Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 4, 2020

This issue is automatically created based on existing pull request: #31162: Allow to load base64 encoded images and fonts


Description

Magento 2.4-develop

Current Content Security Policy setup doesn't allow to load images and fonts via data: scheme which is quite a popular method to load local resources (base64 encoded images). Additionally, it's used internally by the browser cache (Chrome) when you refresh the page.

Manual testing scenarios (*)

  1. Add Base64 image or font to Home page
  2. Open Luma homepage and open browser console.
  3. Refresh the page to trigger resource loading from the browser cache.
  4. Inspect errors in the console:

Font errors in console

5. Apply the patch, and try again. No errors should appear in the log.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Csp Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 4, 2020
@engcom-Alfa engcom-Alfa added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Dec 24, 2020
@engcom-Alfa engcom-Alfa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 24, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-40224 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #31162 by @vovayatsyuk in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Csp Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants