Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Fix issue with logging each cookie as separate context #31471

Closed
m2-assistant bot opened this issue Dec 28, 2020 · 4 comments · Fixed by #31334
Closed

[Issue] Fix issue with logging each cookie as separate context #31471

m2-assistant bot opened this issue Dec 28, 2020 · 4 comments · Fixed by #31334
Labels
Component: Stdlib Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 28, 2020 •
edited by magento-engcom-team
Loading

This issue is automatically created based on existing pull request: #31334: Fix issue with logging each cookie as separate context

Description (*)

When the number of cookies becomes more than 50 the warning log is written: "Unable to send the cookie. Maximum number of cookies would be exceeded." And each cookie is converting to a separate log context. And in the case of using the Graylog app, it is converting to a separate field.
By this pull request, the $_COOKIE array is converting to a string and writing as 'cookie' context while writing the log

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Exceed the number of cookies > 50
  2. Watch the log

Preconditions

Magento 2.4-develop

Steps to reproduce

  1. Open web browser Firefox
  2. Navigate to about:config
  3. Find dom.storage.enabled option and change to false
  4. Open Storefront in a new tab
  5. Duplicate the tab, open the same page in another tab
  6. Duplicate the tabs several times (3-4 new tabs)
  7. Open debug.log file from ./var/log folder
  8. Find the text "main.WARNING: Unable to send the cookie. Maximum number of cookies would be exceeded"

Actual Result

unableto sendcoockie

Expected Result

unableto send_coockieafter
@m2-assistant m2-assistant bot added Component: Stdlib Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Dec 28, 2020
@m2-assistant m2-assistant bot mentioned this issue Dec 28, 2020
Merged
5 tasks
@engcom-Bravo engcom-Bravo added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 28, 2020
@magento-engcom-team
Copy link
Contributor

@engcom-Bravo Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 28, 2020
@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Dec 28, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-40244 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jan 6, 2021
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #31334 by @aleksinoleg in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot].

Thank you for your report and collaboration!

The related internal Jira ticket MC-40244 was closed as Fixed.

The fix will be available with the upcoming 2.4.3 release.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Stdlib Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with logging each cookie as separate context
2 participants
@magento-engcom-team @engcom-Bravo