Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Ensure that invoice comments are returned when requested by GraphQL queries #31866

Closed
3 of 5 tasks
m2-assistant bot opened this issue Jan 27, 2021 · 1 comment · Fixed by #31606
Closed
3 of 5 tasks

[Issue] Ensure that invoice comments are returned when requested by GraphQL queries #31866

m2-assistant bot opened this issue Jan 27, 2021 · 1 comment · Fixed by #31606
Assignees
Labels
Component: SalesGraphQl Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jan 27, 2021

This issue is automatically created based on existing pull request: #31606: Ensure that invoice comments are returned when requested by GraphQL queries


Description (*)

As part of the GraphQL schema for customer orders, invoices can be requested, along with their comments. However, the current implementation does not return any comments for invoices, resulting in a null value always.
This pull request ensures that invoice comments (that are visible in the front-end) are returned when requested in the query.

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Create a customer order and an associated invoice.
  2. Add a number of comments to an order invoice, including both visible and not visible in the front-end.
  3. Call the customer GraphQL query, requesting orders, invoices and their associated comments - e.g:
query {
    customer {
        orders(filter: { number: { eq: "000000154" } }) {
            items {
                invoices {
                    comments {
                        message
                        timestamp
                    }
                    items {
                        product_name
                    }
                }
            }
        }
    }
}

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Ensure that invoice comments are returned when requested by GraphQL queries #31643: Ensure that invoice comments are returned when requested by GraphQL queries
@m2-assistant m2-assistant bot added Component: SalesGraphQl Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jan 27, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Jan 27, 2021
@aligent-lturner
Copy link
Contributor

This is a duplicate of #31643

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: SalesGraphQl Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
2 participants