Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Cart broken on lists view with redirect to cart enabled #32232

Closed
1 of 3 tasks
jeffyl opened this issue Feb 19, 2021 · 9 comments · Fixed by #32301
Closed
1 of 3 tasks

Add to Cart broken on lists view with redirect to cart enabled #32232

jeffyl opened this issue Feb 19, 2021 · 9 comments · Fixed by #32301
Assignees
Labels
Area: Frontend Component: Config Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.

Comments

@jeffyl
Copy link

jeffyl commented Feb 19, 2021

Preconditions (*)

  1. Magento 2.4.2
  2. Redirect to cart enabled

Steps to reproduce (*)

  1. Fresh Magento 2.4.2 with sample data
  2. Enable redirect to cart: https://docs.magento.com/user-guide/sales/cart-redirect.html
  3. Go to a list view in any of the categories and try to add an item to cart from that page

Expected result (*)

  1. Add to cart button is enabled after page finishing loading

Actual result (*)

  1. Add to cart button continues to be disabled

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • < ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ > Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Feb 19, 2021

Hi @jeffyl. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@jeffyl
Copy link
Author

jeffyl commented Feb 19, 2021

The issue starts with 95859dc which defaults the button to be disabled until the catalog-add-to-cart.js is loaded, which enables the buttons. But if you have redirect to cart enabled, require.js never loads that script and so it will not enable the button

https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Catalog/view/frontend/templates/product/list.phtml#L157

@ajijshekh123 ajijshekh123 self-assigned this Feb 22, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 22, 2021

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ajijshekh123
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @ajijshekh123. Thank you for your request. I'm working on Magento instance for you.

@ajijshekh123
Copy link

Hi @jeffyl,
The issue has been reproduced on the Latest Magento 2.4 Instance.
In Admin > Stores > Configuration > Sales > Checkout > After Adding a Product Redirect to Shopping Cart "YES"
In the Front end, the Categories > Product Listing > Add to Cart button is disabled
Screenshot:
image

image

Expected result:
The "Add to Cart" button should be enabled.

Thanks.

@ajijshekh123 ajijshekh123 added Area: Frontend Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Feb 22, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Feb 22, 2021
@m2-community-project m2-community-project bot removed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: ready for confirmation labels Feb 22, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @ajijshekh123
Thank you for verifying the issue. Based on the provided information internal tickets MC-40983 were created

Issue Available: @ajijshekh123, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ajijshekh123 ajijshekh123 added Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Component: ConfigurableProduct Component: Config and removed Component: ConfigurableProduct labels Feb 22, 2021
@engcom-Bravo engcom-Bravo added Reported on 2.4.2 Indicates original Magento version for the Issue report. Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels Feb 24, 2021
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Feb 24, 2021
@engcom-Kilo engcom-Kilo self-assigned this Feb 24, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 24, 2021

Hi @engcom-Kilo. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Feb 24, 2021
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Feb 24, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Feb 26, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Feb 26, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Feb 26, 2021
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Feb 26, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Config Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Development

Successfully merging a pull request may close this issue.

6 participants