-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue] Made address street line translation dynamic #32372
Comments
Hi @engcom-Bravo. Thank you for working on this issue.
|
@magento give me 2.4-develop instance |
Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Bravo, here is your Magento Instance: https://5a1c21e5bd80e9bb3dd319ce8b833dda.instances-prod.magento-community.engineering |
Hi @reense, Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots. Manual testing scenarios
We are able to see the two line under street address and we are able to save the address as per the description mentioned. Kindly recheck the issue in Latest Magento 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible. Thanks. |
@engcom-Bravo the lines function normally, however we cannot change the translation of those fields since it's translated via the string If you want to change the translation, you'll have to copy a lot of template code, which in turn is bad for upgradability. |
Hi @reense, Thanks for your quick response. We agree with your enhancement to proceed further we are confirming the issue. Thanks. |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-11589 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue. |
This issue is automatically created based on existing pull request: #32365: Made address street line translation dynamic
Description (*)
Currently, trying to add 'Street' above the first address line and 'House number' above the second address line is not possible because of the way the labels for the street lines are translated. In the current situation it is only possible to change the 'Street Address' text, which in most cases (at least, for us) is not what you want.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
I am not sure if the proposed solution is the way-to-go. However, I feel like this issue should be pointed out. Any other solution to this problem are welcome.
Contribution checklist (*)
The text was updated successfully, but these errors were encountered: