Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Made address street line translation dynamic #32372

Open
4 tasks done
m2-assistant bot opened this issue Mar 4, 2021 · 9 comments · May be fixed by #32365
Open
4 tasks done

[Issue] Made address street line translation dynamic #32372

m2-assistant bot opened this issue Mar 4, 2021 · 9 comments · May be fixed by #32365
Labels
Area: Account Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Mar 4, 2021

This issue is automatically created based on existing pull request: #32365: Made address street line translation dynamic


Description (*)

Currently, trying to add 'Street' above the first address line and 'House number' above the second address line is not possible because of the way the labels for the street lines are translated. In the current situation it is only possible to change the 'Street Address' text, which in most cases (at least, for us) is not what you want.
Screenshot 2021-03-04 at 14 36 41

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to Stores > Configuration > Customers > Customer Configuration > Name and address options
  2. Set the value of "Number of Lines in a Street Address" to at least 2
  3. Create an account, login, and navigate to the customer account section
  4. Open the address book and create a new address
  5. See the two lines under "Street Address"

Questions or comments

I am not sure if the proposed solution is the way-to-go. However, I feel like this issue should be pointed out. Any other solution to this problem are welcome.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Customer Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. labels Mar 4, 2021
@m2-assistant m2-assistant bot linked a pull request Mar 4, 2021 that will close this issue
5 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Mar 4, 2021
@engcom-Bravo engcom-Bravo self-assigned this Mar 7, 2024
Copy link
Author

m2-assistant bot commented Mar 7, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Copy link

@engcom-Bravo
Copy link
Contributor

Hi @reense,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Manual testing scenarios

  • Go to Stores > Configuration > Customers > Customer Configuration > Name and address options
  • Set the value of "Number of Lines in a Street Address" to at least 2
  • Create an account, login, and navigate to the customer account section
  • Open the address book and create a new address
  • See the two lines under "Street Address"

Screenshot from 2024-03-12 12-23-05

Screenshot from 2024-03-12 12-23-27

We are able to see the two line under street address and we are able to save the address as per the description mentioned.

Kindly recheck the issue in Latest Magento 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Mar 12, 2024
@reense
Copy link
Contributor

reense commented Mar 12, 2024

@engcom-Bravo the lines function normally, however we cannot change the translation of those fields since it's translated via the string Street Address %1. There is no way to distinguish the first, from the second line, since they both get translated with Street Address %1.

If you want to change the translation, you'll have to copy a lot of template code, which in turn is bad for upgradability.

@engcom-Bravo
Copy link
Contributor

Hi @reense,

Thanks for your quick response.

We agree with your enhancement to proceed further we are confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Area: Account Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: needs update Additional information is require, waiting for response labels Mar 13, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11589 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented Mar 13, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Account Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Low Priority Backlog
  
Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

3 participants