Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made address street line translation dynamic #32365

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

reense
Copy link
Contributor

@reense reense commented Mar 4, 2021

Description (*)

Currently, trying to add 'Street' above the first address line and 'House number' above the second address line is not possible because of the way the labels for the street lines are translated. In the current situation it is only possible to change the 'Street Address' text, which in most cases (at least, for us) is not what you want.
Screenshot 2021-03-04 at 14 36 41

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to Stores > Configuration > Customers > Customer Configuration > Name and address options
  2. Set the value of "Number of Lines in a Street Address" to at least 2
  3. Create an account, login, and navigate to the customer account section
  4. Open the address book and create a new address
  5. See the two lines under "Street Address"

Questions or comments

I am not sure if the proposed solution is the way-to-go. However, I feel like this issue should be pointed out. Any other solution to this problem are welcome.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Made address street line translation dynamic #32372: Made address street line translation dynamic

…er line

To make it possible for translators to give unique labels to every address line.
@m2-assistant
Copy link

m2-assistant bot commented Mar 4, 2021

Hi @reense. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Mar 4, 2021
@gabrieldagama gabrieldagama added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Mar 4, 2021
@gabrieldagama
Copy link
Contributor

@magento create issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Customer Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: pending review Release Line: 2.4
Projects
Pull Requests Dashboard
  
Pending Review
Development

Successfully merging this pull request may close these issues.

[Issue] Made address street line translation dynamic
3 participants