Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrity and crossorigin with external stylesheets not working #32509

Closed
Zyles opened this issue Feb 25, 2019 · 5 comments · Fixed by #32455
Closed

Integrity and crossorigin with external stylesheets not working #32509

Zyles opened this issue Feb 25, 2019 · 5 comments · Fixed by #32455
Assignees
@erfanimani
Labels
Area: UI Framework Component: Css Component: Theme Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog

Comments

@Zyles
Copy link

Zyles commented Feb 25, 2019 •
edited by engcom-Oscar

Preconditions (*)

  1. Magento 2.3.0
  2. PHP 7.1

Steps to reproduce (*)

  1. Edit app/design/frontend/<Vendor>/<theme>/Magento_Theme/layout/default_head_blocks.xml
  2. Try to include a CDN CSS or JS like Bootstrap for example: <link rel="stylesheet" src_type="url" src="https://stackpath.bootstrapcdn.com/bootstrap/4.3.1/css/bootstrap.min.css" integrity="sha384-ggOyR0iXCbMQv3Xipma34MD+dH/1fQ784/j6cY/iJTQUOhcWr7x9JvoRxT2MZw1T" crossorigin="anonymous"/>
  3. Error: attribute integrity and crossorigin not supported

Expected result (*)

Ability to import external CSS and JS using modern methods and requirements

Actual result (*)

Errors saying attributes integrity and crossorigin is not supported.
@sivaschenko sivaschenko transferred this issue from magento/community-features Mar 16, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 16, 2021

Hi @Zyles. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Mar 16, 2021
@sivaschenko sivaschenko mentioned this issue Mar 16, 2021
Merged
4 tasks
@sivaschenko sivaschenko linked a pull request Mar 16, 2021 that will close this issue
Added attribute crossorigin to head.xsd for linkTypes #32455
Merged
4 tasks
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Mar 29, 2021
@engcom-Oscar engcom-Oscar added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Mar 29, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Mar 29, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Mar 29, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Mar 29, 2021
@engcom-Oscar engcom-Oscar added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 29, 2021
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Mar 29, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-41625 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Lima engcom-Lima added Component: Theme Reported on 2.3.0 Indicates original Magento version for the Issue report. Area: UI Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 24, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-8039 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Feb 24, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@erfanimani
Copy link
Contributor

There's a PR here also: #32455

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erfanimani erfanimani

Labels
Area: UI Framework Component: Css Component: Theme Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added attribute crossorigin to head.xsd for linkTypes erfanimani/magento2
6 participants
@erfanimani @Zyles @magento-engcom-team @engcom-Lima @engcom-Oscar @github-jira-sync-bot