Added attribute crossorigin to head.xsd for linkTypes #32455

erfanimani · 2021-03-12T03:49:18Z

Description (*)

Allows the crossorigin attribute to be added to link types, for HEAD elements, in as per https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/crossorigin

Related Pull Requests

N/A

Fixed Issues (if relevant)

These issues/features are related:

Manual testing scenarios (*)

Add <css src="https://my.cdn.com/style.min.css" media="screen" src_type="url" crossorigin="anonymous"/> to default_head_blocks.xml
Ensure crossorigin attribute is added correctly and doesn't break the site with an XSD error

Questions or comments

There's probably already some work in the pipeline regarding this work, but I thought I would create a PR anyway as I need the diff for a patch.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-03-12T03:49:20Z

Hi @erfanimani. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

ihor-sviziev

Hi @erfanimani,
Could you cover your changes with some kind of test?

erfanimani · 2021-03-15T00:25:46Z

Hi @ihor-sviziev, thanks for the feedback. I don't think a unit test or functional test is fitting for a pure XSD change. Do you have any suggestions?

ihor-sviziev · 2021-03-15T08:59:15Z

Yeah, it seems like we don't have any test coverage for XSD schemas. Let's not cover it.

@magento run all tests

ihor-sviziev · 2021-03-15T15:11:26Z

@magento run WebAPI Tests

ihor-sviziev

✔ Approved

Failing WebAPI tests looks not related to changes from this PR. The SVC failure probably should be approved additionally.

magento-engcom-team · 2021-03-15T15:13:50Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8929 has been created to process this Pull Request

As documented here: https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity

erfanimani · 2021-03-17T01:41:38Z

Thanks all. I've also added the attribute integrity, as the referenced issue: #32509

(https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity)

@magento run all tests

ihor-sviziev · 2021-03-17T09:30:19Z

@magento run all tests

ihor-sviziev · 2021-03-17T15:02:37Z

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests
Changes still looks good, Approved from my side.

magento-automated-testing · 2022-11-04T06:53:19Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2023-09-11T09:42:07Z

@magento run Semantic Version Checker

magento-automated-testing · 2023-09-11T09:42:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Charlie · 2024-01-24T07:09:23Z

@magento run all tests

magento-automated-testing · 2024-01-24T07:09:29Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Charlie · 2024-01-24T09:19:40Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

magento-automated-testing · 2024-01-24T09:19:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Charlie · 2024-01-24T11:44:42Z

As we got the SVC approval mentioned in here and the build is green now moving this PR to Merge in Progress.

erfanimani · 2024-01-24T16:47:09Z

It took some time, but is finally happening :)

Added attribute crossorigin to head.xsd for linkTypes

c2e0368

magento-engcom-team added Component: View Release Line: 2.4 labels Mar 12, 2021

m2-community-project bot added the Progress: pending review label Mar 12, 2021

ihor-sviziev requested changes Mar 12, 2021

View reviewed changes

m2-community-project bot assigned ihor-sviziev Mar 12, 2021

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Mar 12, 2021

ihor-sviziev added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix labels Mar 12, 2021

m2-community-project bot removed the Progress: review label Mar 15, 2021

ihor-sviziev approved these changes Mar 15, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Mar 15, 2021

ihor-sviziev added the Risk: low label Mar 15, 2021

gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 16, 2021

sivaschenko linked an issue Mar 16, 2021 that may be closed by this pull request

Integrity and crossorigin with external stylesheets not working #32509

Closed

Added attribute integrity to head.xsd for linkTypes

08220a3

As documented here: https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity

m2-community-project bot added Progress: pending review Progress: pending approval and removed Progress: pending approval Progress: pending review labels Dec 14, 2022

engcom-Lima removed the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Feb 24, 2023

m2-community-project bot added Progress: ready for testing Progress: pending approval and removed Progress: pending approval Progress: ready for testing labels Feb 24, 2023

erfanimani mentioned this pull request Feb 26, 2023

Integrity and crossorigin with external stylesheets not working #32509

Closed

sinhaparul added the Project: Community Picked PRs upvoted by the community label Mar 4, 2023

m2-community-project bot added Progress: ready for testing and removed Progress: pending approval labels Mar 4, 2023

sinhaparul added Progress: pending approval and removed Progress: ready for testing labels Mar 4, 2023

m2-community-project bot added Progress: testing in progress and removed Progress: pending approval labels Jan 24, 2024

Merge branch '2.4-develop' into add-crossorigin-attribute-to-link

e6c7382

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Jan 24, 2024

magento-devops-reposync-svc merged commit ebbb127 into magento:2.4-develop Feb 24, 2024

Added attribute crossorigin to head.xsd for linkTypes #32455

Added attribute crossorigin to head.xsd for linkTypes #32455

Uh oh!

Conversation

erfanimani commented Mar 12, 2021 • edited by sivaschenko Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Mar 12, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

erfanimani commented Mar 15, 2021

Uh oh!

ihor-sviziev commented Mar 15, 2021

Uh oh!

ihor-sviziev commented Mar 15, 2021

Uh oh!

ihor-sviziev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Mar 15, 2021

Uh oh!

erfanimani commented Mar 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ihor-sviziev commented Mar 17, 2021

Uh oh!

ihor-sviziev commented Mar 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magento-automated-testing bot commented Nov 4, 2022

Uh oh!

engcom-Charlie commented Sep 11, 2023

Uh oh!

magento-automated-testing bot commented Sep 11, 2023

Uh oh!

engcom-Charlie commented Jan 24, 2024

Uh oh!

magento-automated-testing bot commented Jan 24, 2024

Uh oh!

engcom-Charlie commented Jan 24, 2024

Uh oh!

magento-automated-testing bot commented Jan 24, 2024

Uh oh!

engcom-Charlie commented Jan 24, 2024

Uh oh!

erfanimani commented Jan 24, 2024

Uh oh!

Uh oh!

erfanimani commented Mar 12, 2021 •

edited by sivaschenko

Loading

ihor-sviziev left a comment •

edited

Loading

erfanimani commented Mar 17, 2021 •

edited

Loading

ihor-sviziev commented Mar 17, 2021 •

edited

Loading